-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elm update fails when using 1Password X Chrome extension #147
Comments
I can confirm this also in Firefox w/ 1Password. viewInput : String -> String -> String -> (String -> msg) -> Html msg
viewInput t p v toMsg =
span [] [ input [ type_ t, placeholder p, value v, onInput toMsg ] [] ] I'm happy to PR this on the docs as I could see this being a deal-breaker for newcomers. |
I don't know much about how the virtual-DOM-renderer operates, but it would be nice to understand why wrapping it in a span fixes it. Would it be possible for the renderer to detect these scenarios and still work (I noticed that sometimes it falls back to recreating the instead of updating elements?). |
I just encountered this problem as well. Here is how I am working around it at the moment. It might be useful to someone else.
|
@alvinlindstam Agreed, and I believe this issue should remain open even if my PRs are merged. Also worth noting I see a different error message.
|
Same issue on my side |
I'm also experiencing the same issue. Following the guide at https://guide.elm-lang.org/architecture/forms.html and using Firefox with 1password, the rendered input fields do not respond to keyboard input correctly. Disabling the 1password extension restores expected behavior. |
This was previously reported in elm/compiler#1735, and noted to probably be fixed in 0.19.0.
I'm running elm 0.19.0 and get that error when running https://github.com/evancz/elm-architecture-tutorial/blob/bbe9e3f76a2415734349583f562465e45c1c6f46/examples/03-form.elm with two minor modifications:
System information:
OS: Mac OS X 10.13.6
Browser: Version 70.0.3538.77 (Official Build) - current release
Interfering extension: 1Password X - Password manager, version 1.12.2 (current release). The error does not happen when the extension is deactivated.
What would be expected:
Interacting with the password fields (such as typing) should work, even when a common browser extension injected extra markup (not a simple thing, I know).
What happens:
Exception:
The compiled file:
03-form.elm.txt
As noted in the other issue, 1Password injects some markup into password fields, which for me was:
The first password field also got the attribute
data-op-id="0"
The text was updated successfully, but these errors were encountered: