Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form example compatibility w/ 1Password extension #185

Closed
wants to merge 1 commit into from

Conversation

craiglyons
Copy link

@craiglyons craiglyons commented Jan 13, 2019

Problem:
The form example does not work with the 1Password browser extension in Chrome and Firefox. It may also be affected by other browsers / extensions.

Solution:
Wrap inputs in a span element. This is applied to the function that generates the input elements, which gives the fix a very small footprint.

Related to:
elm/virtual-dom#147
evancz/elm-architecture-tutorial#132

@craiglyons craiglyons changed the title Wrap example form inputs in a span for compatibility with password Form example compatibility w/ 1Password extension Jan 13, 2019
@evancz
Copy link
Owner

evancz commented Feb 3, 2019

I think it's important to not have extra stuff, and independent of the importance of this topic, I think getting into compatibility with extensions is out of scope for this part of the book.

@evancz evancz closed this Feb 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants