New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resizable debugger sidebar #46
Conversation
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it! Here is what to expect next, and if anyone wants to comment, keep these things in mind. |
Very nice - thanks! |
This won't solve things for more complex messages. For example, if you have |
I don't understand why this would be true. Can you elaborate?
Showing a single message? If you have 40 messages down the side and they all start Being able to scan through your messages seems important. |
in | ||
VDom.div | ||
[ VDom.class className | ||
, VDom.on "click" (Decode.succeed index) | ||
] | ||
[ VDom.span [VDom.class "messages-entry-content"] [ VDom.text (Native.Debug.messageToString msg) ] | ||
[ VDom.span [VDom.class "messages-entry-content", VDom.title messageName ] [ VDom.text messageName ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently it seems this would not compile, because VDom.title
is missing from helpers.
I am trying to understand why this PR did not get accepted. |
Could I suggest breaking this up into two separate PRs? One for As an aside, is there any good reason to not have a resizable column and show the message on the right? |
Like @mbylstra said, I'd really love for this to be split up, and the All of my practical work happens a few layers down in the messages, so the built-in debugger is useless for my most common debugging task, which is seeing which actions were fired. Right now I'm using https://github.com/jinjor/elm-time-travel since I can see the complete action names, but I guess my app is complicated enough that enabling that debugger significantly degrades the performance of the app. I think that just the |
I did a thing instead of making @rtfeldman do it: https://github.com/elm-lang/virtual-dom/pull/76 |
Thanks @splodingsocks! Closing in favor of #76 |
Nice that the hover gives you the info, but what about the pretty great resizing? |
This addresses the reported issue with long messages becoming unreadable. It does two things:
title
to each of the messages, so if it's truncated you can hover over it to see more.resize:horizontal
to the sidebar, so you can drag-to-resize it like atextarea
.