Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine test environment and track test coverage. #24

Closed
wants to merge 3 commits into from

Conversation

boennemann
Copy link
Contributor

Karma now tests the built code and generates code coverage reports.

screen shot 2014-04-29 at 01 34 44

I'd love to set up coveralls, but I'd need push access to set the required env variables for Travis.

I removed an incorrect test, so we should now at least be back to green.

The grunt dev task isn't working correctly atm, because karma keeps telling me Waiting for previous execution.... I suspect there is a hanging test so the testing session isn't closed down. But maybe I'm missing something obvious there, dunno. I'll investigate some more.

Also seperates the build task from the test task so tests don't run twice on save.
Probably it's more semantic, too.
@robinboehm
Copy link
Collaborator

Nice! :) thx @boennemann
Which env variables for travis?
Couldn't find a hint in the documentation of coveralls.

@boennemann
Copy link
Contributor Author

The coveralls token COVERALLS_REPO_TOKEN needs to be set as encrypted environment variable.

@boennemann
Copy link
Contributor Author

Can we merge this? Coveralls can be done in a separate PR (:

@robinboehm
Copy link
Collaborator

I've done a rebase and added your chore commits :)
Thx @boennemann! :)

@robinboehm robinboehm closed this May 11, 2014
@boennemann boennemann deleted the test-env branch May 11, 2014 14:09
@robinboehm robinboehm mentioned this pull request Jun 22, 2014
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants