Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to override language returned by _getUserLanguage #61

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

urbanecm
Copy link

@urbanecm urbanecm commented Nov 9, 2020

Some users might have a project that can change languages, and instead
of localizing the strings on their own, they might want to re-use
i18n baked into this plugin.

Downstream bug: https://phabricator.wikimedia.org/T267591

Some users might have a project that can change languages, and instead
of localizing the strings on their own, they might want to re-use
i18n baked into this plugin.
@urbanecm
Copy link
Author

Ping? Any updates on this one, please? :)

Copy link

@mauriciabad mauriciabad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition.

Would be nice to add proper types (union of literals)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants