Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onReceivePhoneCall not userId #39

Closed
aboire opened this issue Aug 28, 2017 · 6 comments
Closed

onReceivePhoneCall not userId #39

aboire opened this issue Aug 28, 2017 · 6 comments
Assignees
Labels

Comments

@aboire
Copy link

aboire commented Aug 28, 2017

The function this.onReceivePhoneCall (msg.id); Do not return the userId but the msg.id
https://github.com/elmarti/meteor-video-chat/blob/master/services/client.js#L48

@elmarti
Copy link
Owner

elmarti commented Aug 28, 2017

Nice spot, I'll have a look at this today.

SOLUTION:
Update the following callback:
this.onReceivePhoneCall(msg.id);

to be

this.onReceivePhoneCall(msg.fields.caller);

This task is also an opportunity to review all of the callbacks and ensure that they are being ultilised correctly.

@aboire
Copy link
Author

aboire commented Aug 28, 2017

@aboire
Copy link
Author

aboire commented Aug 28, 2017

For the browser and desktop (electron) is ok, I will test with cordova (crosswalk) I think I need to add permissions

@aboire
Copy link
Author

aboire commented Aug 28, 2017

Ok it works without permission in addition with crosswalk :)

@elmarti
Copy link
Owner

elmarti commented Aug 28, 2017

Great, thanks a lot for that, I wasn't going to get time to check any time soon

@elmarti
Copy link
Owner

elmarti commented Aug 28, 2017

All fixed and tested, thanks for the heads up https://github.com/elmarti/meteor-video-chat/releases/tag/1.0.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants