-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild does not work #56
Comments
have the same issue with my hotio/qbittorrent docker It looks like in Unraid 6.10-RC2 the networking/mode is deleted from the XML after editing docker settings. following section is missing Networking |
From the UnRAID 6.10-RC2 Release Notes webgui: Docker: Only save templates as v2 |
same Problem here.
So its a UnRAID 6.10-RC2 thing? |
Looks like from 6.10RC2 onwards docker templates are saved in v2 format. If you edit / change the template to suit your needs. Somehow your script can’t interpret the right values to rebuild the docker.
…________________________________
Van: paskalll ***@***.***>
Verzonden: Wednesday, February 2, 2022 5:34:13 PM
Aan: elmerfdz/rebuild-dndc ***@***.***>
CC: EdwinKlemann ***@***.***>; Comment ***@***.***>
Onderwerp: Re: [elmerfdz/rebuild-dndc] Rebuild does not work (#56)
same Problem here.
From the UnRAID 6.10-RC2 Release Notes
webgui: Docker: Only save templates as v2
So its a UnRAID 6.10-RC2 thing?
—
Reply to this email directly, view it on GitHub<#56 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABYDFEFCOPYMZDG34PEEFH3UZFMILANCNFSM5EKEGRZQ>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you commented.Message ID: ***@***.***>
|
Seems like this is an issue with 6.10+ final as well (currently on 6.10.2). Would your script be modifiable to address the new changes? |
@EdwinKlemann @knaackville @soonic6 @paskalll Long story short, I won't be having access to my Unraid server until later this year. I've merged @DiamondPrecisionComputing 's pull request, which hopefully solves this issue, could you guys please pull and test? |
@elmerfdz does not work for me.
VPN Container will be detected as "broken" every scan and the slave wont be rebuild. |
@soonic6 I'm assuming you are using ich777's OpenVPN-Client. Did you reame the container to all under case letters? The docker exec command used to check network connectivity is case sensitive. |
yes i do and i renamed the container before unsing it. this was working before unraid 6.10.x |
@soonic6 for now disable the master container connectivity check by adding an env variable to the rebuild-dndc container I'm wondering if iputils-ping is not installed on ich777's OpenVPN-Client container. Try the following: Check if the above command works, if it doesn't, also double check by SSH directly into your 'openvpn-client' container and do a ping: |
you are right, "ping" is not installed on ich777's container. edit: |
Cool! You've got couple of options:
|
@elmerfdz
He added ping to his container. i tried
Before the "Scan" i restarted openvpn-client container to force a new NETID. The |
Issue remains, containers are not being rebuilt. |
Seeing the same issue, containers wont be rebuilt.
|
Has anyone figured out a way around this or an alternative with 6.10+? Is this (v2 change) the root cause of issue #59 as well? |
The v2 change was the root cause of that issue also. |
Hm. Updated then ran the new version of rebuild-dndc and it created orphaned images of all of the dependent dockers. Possibly due to this error:
|
Is your ‘nzbgetvpn’ container up and running? Check if your vpn container name matches what you’ve set on your dependent container templates |
Yes, it was running (and is still running) and is set as the master container in rebuild-dndc. The dockers all function and build normally when doing it manually; just rebuilt them manually again without issue. Seems like it might not like if you set your children dockers up using |
Oh think you’re right about building dependent containers using --net=container:parentdockername. Feel like I remember seeing something about that. I don’t have access to my server yet to look into this, so hoping @Phil-Barker might look at this issue for you |
@ste7enm remove
https://github.com/elmerfdz/rebuild-dndc#prerequisites see if linking them using the above method makes any difference. |
Thanks, @elmerfdz – I can't remember why I'd swapped container network type, but I swapped back (like you recommended) and rebuild-dndc ran without issue. Will leave it running for a few days and post again if there are any v2 issues when it actually needs to rebuild. Appreciate the docker update from Sat / Sun, @Phil-Barker. Was really missing this docker / feeling the pain of not having it. |
Its working great work thx. But now i am struggling with an old Problem. I have two instances of Radarr and Sonarr from the same image. And it's only rebuilding one because radarr already exists. Can I resolve this problem somehow? |
Is this an issue again? I am using gluetun with qbittorent passed through it. I have made sure master container (gluetun) is all lower case letters and have used the method of creating a custom docker network instead of "--network:container:gluetun". When I stop the gluetun container it seems on the next run of rebuild-dndc it just skips the dependent container. |
I haven't seen any issues with this all year...
But then I don't run gluetun Where yours is outputting I believe by default it pings 1.1.1.1 and 8.8.8.8 which from memory are cloudflare and google DNS servers.... so you might want to start by connecting into the gluetun container and confirming it has internet connectivity :) |
Can't imagine that but you can test it when you bin/bash into the gluten container and try to ping 1.1.1.1 Check #52 Known behaviour is a restart loop of all containers. I guess it's something else. Would be helpful if you post your dockerfile or what ever And why are you even ask here ? This issue has nothing to do with your problem. Check the op log and your log. Completely different man |
@soonic6's issue on Jun 17, 2022 is the same as mine, where the endpointID is not being detected. So yes not the same issue as the original post, but it was an issue in this thread. Anyway I won't worry about this. I'm running Unraid and using ProtonVPN so I needed an easy way for the dynamic forwarded port to be overwritten in qbittorrent and there is no easy Unraid community app to do it without me doing anything custom. So I've moved from Gluetun to just directly using binhex-qbittorrentvpn which has all the functionality packed in to one container. I don't really have any dependent containers to worry about at this point |
the binhex containers are really good - as you can see on my setup I use qbittorrentvpn with all of the *arr routed through it. Works flawlessly |
I'm running the latest build of gluetun (for Mullvad) on Unraid 6.11.5 and there's no issues detecting connectivity, so not quite sure what's different with @nickydd9 's setup. |
I think I figured out what my issue was. I think I misunderstood what rebuild-dndc is supposed to do. What I was testing was specifically STOPPING the VPN container, and was then hoping once it was stopped that it would be restarted along with the other dependent containers rebuilt and started. When I would stop the VPN container is when it would then show "broken". I don't think that is what this is meant to do though right? Honestly not really sure what the point of rebuild-dndc is.... looking at this thread functionality was added natively to Unraid to rebuild dependent containers when the master VPN container is rebuilt or updated, and that's working for me: https://forums.unraid.net/topic/84167-better-handling-of-to-container-docker-network-binding/ |
@nickydd9 no that's not the purpose. The purpose is that when the master container that the others are routed through restarts, this goes through the child containers and ensures the network link is correct. The thread you linked on the unraid forum just states to use this app as a solution, there is no native support in unraid. So not sure what you mean there? If you just want the gluetun container to always restart if it crashes just tick the autostart option in Unraid. |
@Phil-Barker sure but in that unraid forum I linked it clearly mentions that when you rebuild/update the VPN master container, any dependent containers are automatically rebuilt along with it. That was the functionality they say was added and that is confirmed working for me. So the only real use case for rebuild-dndc then would simply just be if you restarted (but not rebuilt) the VPN master container because now you severed the dependent containers right? I get what you mean about if the VPN master container actually is completely crashed, thats a whole separate deal then. My bad on that. |
@nickydd9 see some of my (user: eafx) comments on that thread. Rebuild-DNDC was created before Unraid had any sort of native support for what Rebuild-DNDC is/was intended to do. Last when I checked i.e. when that linked thread was created, there was a lot of manual intervention required for Unraid to rebuild dependent containers, examples:
Not sure if any of the above has changed in the latest Unraid builds but was true back then. @Phil-Barker thanks! once again for your help. |
@elmerfdz you do not have to click the docker page anymore, it just auto-rebuilds them. If my master container loses VPN e.g. let's say I completely unplug the uplink cable on my router leading to my ISP modem, and then reinsert it the dependent containers are not impacted, they still work and regain connectivity. However the one branch case is what @Phil-Barker described in which if the master VPN container is restarted (not rebuilt) then it does then sever the dependent containers. And that's where rebuild-dndc might still be useful. |
FWIW since I'm getting notifications about this thread's activity, I swapped master containers recently and went back to using the |
Hello,
today i saw, that the Container rebuild doen't work anymore.
I tested unraid-m, unraid-d and unraid-e, with some other containers.
Same problem with unsing
--net=
in extra parametersUnraid Version 6.10.0-RC2d and RC2e
The text was updated successfully, but these errors were encountered: