Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No UI refresh when travel debug / replay is enabled. #62

Open
zpodlovics opened this issue Jul 30, 2023 · 3 comments
Open

No UI refresh when travel debug / replay is enabled. #62

zpodlovics opened this issue Jul 30, 2023 · 3 comments

Comments

@zpodlovics
Copy link

zpodlovics commented Jul 30, 2023

Description

No UI refresh when travel debug / replay is enabled.

Repro code

  1. Create a new awesome app using the elmish template as of https://github.com/elmish/templates
  2. Install redux devtools extension (firefox in my case)

Expected and actual results

Expected result:
UI refresh.

Actual result:

The counter value should be 0 in this case.

Screenshot from 2023-07-30 21-57-21

Related information

  • elmish version: 4.0.1
  • fable-compiler version:4.1.4
  • fable-core version: 4.0
  • Operating system: Ubuntu 22.04

paket.lock.zip

It seems that the interaction between the components are complicated especially when react and stores are involved. Would it be impossible to provide a way to refresh the ui (functionality) for the debugger?

@et1975
Copy link
Member

et1975 commented Jul 31, 2023

Thanks for the report!
I don't recall if I ever tried this in FF. It's possible some security feature is interfering with the plugin. What is that angry red icon in the status bar? Could you try this in opera/chrome/edge as well? Does it work with standalone DevTools?

@zpodlovics
Copy link
Author

The angry red icon on the status bar is the missing favicon.
Screenshot from 2023-08-06 16-39-23

I also checked it with chrome (fresh install, only redux devtools installed):

Screenshot from 2023-08-06 16-40-30

And edge as well (fresh install, only redux devtools installed):

Screenshot from 2023-08-06 16-41-07

Checking it with standalone devtools is works in progress.

@et1975
Copy link
Member

et1975 commented Sep 14, 2023

I just tried the debugger on our ToDo sample and it works as expected. Looking at the template code I think
|> Program.withReactBatched and |> Program.withDebugger are in reverse order.
@zpodlovics please flip the order of these 2 instructions and try again?
If that does it please open a PR into the template repo to fix this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants