Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mock network in unit tests #8

Open
elmurci opened this issue Apr 1, 2020 · 1 comment
Open

mock network in unit tests #8

elmurci opened this issue Apr 1, 2020 · 1 comment

Comments

@elmurci
Copy link
Owner

elmurci commented Apr 1, 2020

Currently, tests interact with the XRP Ledger when testing some methods.
The TestNet resets from time to time and transactions and account might disappear from one day to the next.

Implement a better way of unit testing methods, probably with mock responses.
@elmurci
Copy link
Owner Author

elmurci commented Apr 1, 2020

This applies also to doc-tests

elmurci added a commit that referenced this issue Apr 1, 2020
@elmurci
doc(test): temporary fix for get_transaction_status test
1848e93 
While issue 8 (#8) is fixed, use an existing transaction hash in the get_transaction_status doc test.
@elmurci elmurci changed the title Remove real test transactions and accounts from tests mock network in unit tests Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elmurci