added support for fasthttp #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitOpsBot
reviewed
Jan 2, 2021
There was a problem hiding this comment.
GoGitOps Review
Grade: A (88.2%)
Files: 6
Issues: 3
gofmt: 100%
go_vet: 100%
golint: 50%
contenttype.go
Line 8: warning: exported var ErrInvalidMediaType should have comment or be unexported (golint)
contenttype.go
Line 9: warning: exported var ErrInvalidMediaRange should have comment or be unexported (golint)
contenttype.go
Line 10: warning: exported var ErrInvalidParameter should have comment or be unexported (golint)
contenttype.go
Line 11: warning: exported var ErrInvalidExtensionParameter should have comment or be unexported (golint)
contenttype.go
Line 12: warning: exported var ErrNoAcceptableTypeFound should have comment or be unexported (golint)
contenttype.go
Line 13: warning: exported var ErrNoAvailableTypeGiven should have comment or be unexported (golint)
contenttype.go
Line 14: warning: exported var ErrInvalidWeight should have comment or be unexported (golint)
contenttype.go
Line 16: warning: comment on exported type Parameters should be of the form "Parameters ..." (with optional leading article) (golint)
contenttype.go
Line 19: warning: comment on exported type MediaType should be of the form "MediaType ..." (with optional leading article) (golint)
contenttype.go
Line 75: warning: exported function SkipWhiteSpaces should have comment or be unexported (golint)
contenttype.go
Line 118: warning: exported function ConsumeType should have comment or be unexported (golint)
contenttype.go
Line 149: warning: exported function ConsumeParameter should have comment or be unexported (golint)
contenttype.go
Line 193: warning: exported function GetWeight should have comment or be unexported (golint)
contenttype.go
Line 232: warning: exported function CompareMediaTypes should have comment or be unexported (golint)
contenttype.go
Line 248: warning: exported function GetPrecedence should have comment or be unexported (golint)
contenttype.go
Line 262: warning: comment on exported function NewMediaType should be of the form "NewMediaType ..." (golint)
fasthttp/mediatype.go
Line 8: warning: comment on exported function GetMediaType should be of the form "GetMediaType ..." (golint)
fasthttp/mediatype.go
Line 48: warning: comment on exported function GetAcceptableMediaType should be of the form "GetAcceptableMediaType ..." (golint)
http/mediatype.go
Line 9: warning: comment on exported function GetMediaType should be of the form "GetMediaType ..." (golint)
http/mediatype.go
Line 49: warning: comment on exported function GetAcceptableMediaType should be of the form "GetAcceptableMediaType ..." (golint)
gocyclo: 50%
http/mediatype.go
Line 51: warning: cyclomatic complexity 26 of function GetAcceptableMediaType() is high (> 15) (gocyclo)
fasthttp/mediatype.go
Line 50: warning: cyclomatic complexity 26 of function GetAcceptableMediaType() is high (> 15) (gocyclo)
contenttype.go
Line 41: warning: cyclomatic complexity 17 of function isTokenChar() is high (> 15) (gocyclo)
ineffassign: 100%
license: 100%
misspell: 100%
This report was generated using GoGitOps.
GitOpsBot
reviewed
Jan 5, 2021
There was a problem hiding this comment.
GoGitOps Review
Grade: A (88.2%)
Files: 4
Issues: 2
gofmt: 100%
go_vet: 100%
golint: 50%
contenttype.go
Line 9: warning: exported var ErrInvalidMediaType should have comment or be unexported (golint)
contenttype.go
Line 10: warning: exported var ErrInvalidMediaRange should have comment or be unexported (golint)
contenttype.go
Line 11: warning: exported var ErrInvalidParameter should have comment or be unexported (golint)
contenttype.go
Line 12: warning: exported var ErrInvalidExtensionParameter should have comment or be unexported (golint)
contenttype.go
Line 13: warning: exported var ErrNoAcceptableTypeFound should have comment or be unexported (golint)
contenttype.go
Line 14: warning: exported var ErrNoAvailableTypeGiven should have comment or be unexported (golint)
contenttype.go
Line 15: warning: exported var ErrInvalidWeight should have comment or be unexported (golint)
contenttype.go
Line 17: warning: comment on exported type Parameters should be of the form "Parameters ..." (with optional leading article) (golint)
contenttype.go
Line 20: warning: comment on exported type MediaType should be of the form "MediaType ..." (with optional leading article) (golint)
contenttype.go
Line 263: warning: comment on exported function NewMediaType should be of the form "NewMediaType ..." (golint)
contenttype.go
Line 310: warning: comment on exported function GetMediaType should be of the form "GetMediaType ..." (golint)
contenttype.go
Line 350: warning: comment on exported function GetAcceptableMediaType should be of the form "GetAcceptableMediaType ..." (golint)
fasthttp.go
Line 7: warning: comment on exported function GetMediaTypeFastHTTP should be of the form "GetMediaTypeFastHTTP ..." (golint)
fasthttp.go
Line 47: warning: comment on exported function GetAcceptableMediaTypeFastHTTP should be of the form "GetAcceptableMediaTypeFastHTTP ..." (golint)
gocyclo: 50%
contenttype.go
Line 352: warning: cyclomatic complexity 26 of function GetAcceptableMediaType() is high (> 15) (gocyclo)
contenttype.go
Line 42: warning: cyclomatic complexity 17 of function isTokenChar() is high (> 15) (gocyclo)
fasthttp.go
Line 49: warning: cyclomatic complexity 26 of function GetAcceptableMediaTypeFastHTTP() is high (> 15) (gocyclo)
ineffassign: 100%
license: 100%
misspell: 100%
This report was generated using GoGitOps.
| "github.com/valyala/fasthttp" | ||
| ) | ||
|
|
||
| // Gets the content of Content-Type header, parses it, and returns the parsed MediaType |
There was a problem hiding this comment.
warning: comment on exported function GetMediaTypeFastHTTP should be of the form "GetMediaTypeFastHTTP ..." (golint)
| return mediaType, nil | ||
| } | ||
|
|
||
| // Choses a media type from available media types according to the Accept |
There was a problem hiding this comment.
warning: comment on exported function GetAcceptableMediaTypeFastHTTP should be of the form "GetAcceptableMediaTypeFastHTTP ..." (golint)
|
|
||
| // Choses a media type from available media types according to the Accept | ||
| // Returns the most suitable media type or an error if no type can be selected | ||
| func GetAcceptableMediaTypeFastHTTP(request *fasthttp.Request, availableMediaTypes []MediaType) (MediaType, Parameters, error) { |
There was a problem hiding this comment.
warning: cyclomatic complexity 26 of function GetAcceptableMediaTypeFastHTTP() is high (> 15) (gocyclo)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should solve #1
downside is, I broke old code since I moved the code to different packages