[ISSUE-8] - Add support for PUT and DELETE http methods #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was thinking, I know there seems to be no point in creating a test for PUT and DELETE. But it's a bit strange to create two new methods without any testing. I think it would be worth thinking or asking someone if they would have a way to test this. One suggestion: make dynamic tests to accept POST, PUT and DELETE in similar way avoiding code duplication. |
| `.delete(url, data [,callbacks] [,config])` | ||
|
|
||
| ###### Description: | ||
| Exeutes an ajax request using `delete` http method. |
There was a problem hiding this comment.
There is a typo here: exeCutes
| `.put(url, data [,callbacks] [,config])` | ||
|
|
||
| ###### Description: | ||
| Exeutes an ajax request using `put` http method. |
There was a problem hiding this comment.
There is a typo here: exeCutes
| @@ -127,7 +125,7 @@ define("ajax", [], function() { | |||
| configHeaders["X-Requested-With"] = configHeaders["X-Requested-With"] || "XMLHttpRequest"; | |||
| } | |||
|
|
|||
| if (method === POST) { | |||
| if (method != GET) { | |||
There was a problem hiding this comment.
What about to use !==?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👍 @diegocesar
ISSUE: #8
Allow use of ajax requests: