More tweaks #88
Merged
More tweaks #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added tests for the Warren function Renamed the `alpha` used in TPU calculations because there is a Licor column called `alpha` `check_required_variables` no longer throws an error if a column is NA
Rename alpha used for calculating Gamma_star Rename alpha used in C4 assimilation
Now we can distinguish between the process (triose phosphate utilization; TPU) and the maximum rate at which the process occurs (Tp)
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## unreleased #88 +/- ##
==============================================
+ Coverage 85.17% 86.11% +0.93%
==============================================
Files 74 74
Lines 3657 3717 +60
==============================================
+ Hits 3115 3201 +86
+ Misses 542 516 -26 ☔ View full report in Codecov by Sentry. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new options for constraining the optimizer during Variable J fits, and makes several other "quality of life" updates