Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 7 #108

Merged
merged 71 commits into from Sep 16, 2023
Merged

Rails 7 #108

merged 71 commits into from Sep 16, 2023

Conversation

christoshrousis
Copy link
Member

@christoshrousis christoshrousis commented Sep 2, 2023

On the back of Heroku pricing tier changes now making the app inaccessible for free, I've decided to undertake a ground up re-write.

The primary outcomes are:

  • Get the application running! ✅
    • The application currently does not run! due to lost package references (unix/docker).
  • Drag the application into the future. ✅
    • Rails 7 introduces a lot of new ideas, it's been a while since I've reviewed the codebase, but there is presumably modern Rails fixes that might address some patches that exist in the codebase
  • Nuke a lot of legacy NodeJS bundler related cruft attributed to Rails past. ✅
  • Nuke Heroku integrations & accomodations. ✅
    • It appears that the majority of infrastructure scripts are written with Heroku in mind (appropriate at the time!) as evidenced by Procfile and other little hints throughout files
    • Difficult to decouple and differentiate what is acceptable best practice, versus legacy cruft from years gone by. ✅

Stretch Goal:

  • Figure out a way to "one click" host the application again for casual, non-developer users. (this was one of the important attributes of this project in the first place) One click appears too difficult.
  • Leverage https://hotwired.dev ✅ Leveraged some features, not all, could be better.
  • Update the UI, maybe even sneak in some tailwind. Tailwind to be reviewing in seperate PR.

Might be a good idea to replace Heroku with "Render", but will fall into the same trap of potentially coupling implementation with platform. Render does not have an appropriate free tier.

@sonarcloud
Copy link

sonarcloud bot commented Sep 16, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 4 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

67.5% 67.5% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.14) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@christoshrousis christoshrousis merged commit e1081d5 into main Sep 16, 2023
2 of 3 checks passed
@christoshrousis christoshrousis deleted the rails-7 branch September 16, 2023 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant