Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start server with correct arguments #1

Closed
bdw429s opened this issue Nov 8, 2016 · 3 comments
Closed

Start server with correct arguments #1

bdw429s opened this issue Nov 8, 2016 · 3 comments

Comments

@bdw429s
Copy link
Collaborator

bdw429s commented Nov 8, 2016

This line
https://github.com/elpete/box-ngrok/blob/master/commands/server/share.cfc#L38
works fine for the default server, but if a specific server name, directory, or config file are passed in to the server share command, those need to be passed along to the server start command to ensure the correct server gets started.

@elpete
Copy link
Owner

elpete commented Nov 9, 2016

Would something like this work?

var serverArgs = duplicate( arguments );
serverArgs.openBrowser = false;
command( "server start" )
    .params( argumentCollection = serverArgs )
    .run();

@bdw429s
Copy link
Collaborator Author

bdw429s commented Nov 9, 2016

Yeah, that should work. The duplicate is probably unnecessary unless either command modifies the arguments. And the entire argument struct isn't necessary but the extras will just be ignored.

@elpete elpete closed this as completed in 14e6456 Nov 10, 2016
@bdw429s
Copy link
Collaborator Author

bdw429s commented Nov 10, 2016

Thanks @elpete !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants