Send notifications on next tick #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jstarry thanks, looks good! I'm thinking we should add a nextTick library that can be used across platforms (node.js, web). |
mkozjak
added a commit
to mkozjak/rpc-websockets
that referenced
this pull request
Aug 26, 2020
Signed-off-by: Mario Kozjak <kozjakm1@gmail.com>
Signed-off-by: Mario Kozjak <kozjakm1@gmail.com>
|
Yes, good call. Want me to close this PR? Your branch looks good to me |
|
@jstarry - no, just merge my pull request in your fork and I’ll merge this PR. |
Use medikoo/next-tick over js' setTimeout
|
@mkozjak done. Do you mind pushing out a patch release for this fix? Not a big rush, but would be nice |
mkozjak
approved these changes
Aug 26, 2020
|
@jstarry: thanks for the PR - the feature is available in 7.1.0! |
|
@mkozjak thanks for the quick turn around! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #83
This is a quick and dirty fix for the race condition. Feel free to go with another approach