Skip to content
This repository has been archived by the owner on Aug 28, 2023. It is now read-only.

Juno-plus integration #5

Open
aminya opened this issue Apr 7, 2020 · 4 comments
Open

Juno-plus integration #5

aminya opened this issue Apr 7, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@aminya
Copy link

aminya commented Apr 7, 2020

I can add buttons for Matlab editor to juno-plus toolbar: For example, Run file, change directory, etc.
https://github.com/aminya/juno-plus

image

This can be done by observing the grammar of active text editor.

@elpollodiablo84
Copy link
Owner

Are you suggesting to add Matlab buttons to juno-plus toolbar? In this case I think it should be a juno-plus feature. In case you need something from my part, let me know, I'll gladly help.

If you are suggesting, instead, to add a similar toolbar to atom-matlab-editor, then I don't know... I'm not a big fan of toolbars, and I would like to avoid too much dependencies from other packages, but if a good number of people want this feature I can work on it.

@aminya
Copy link
Author

aminya commented Apr 7, 2020

I was thinking of adding the callbacks to the current code. That is much easier.
However, I need to check atom-community/tool-bar#290 first.

If it wasn't possible to change callbacks, I can add an option for changing the toolbar language from the juno-plus setting.

@elpollodiablo84 elpollodiablo84 added the enhancement New feature or request label Apr 10, 2020
@elpollodiablo84
Copy link
Owner

Maybe I don't understand the problem, but in atom-matlab-editor the button with the Matlab current directory appears only when the active text editor is a Matlab file. You can have a look to the code if it helps: start with the function checkSessionStatus() in atom-matlab-editor.js, and the StatusBarElement described in statusbar-element.js.

@aminya
Copy link
Author

aminya commented Apr 10, 2020

Definitely possible. We are working on a slicker solution here: atom-community/tool-bar#290

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants