Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add disableFocusLock prop #234

Closed
wants to merge 49 commits into from
Closed

add disableFocusLock prop #234

wants to merge 49 commits into from

Conversation

bellsml
Copy link

@bellsml bellsml commented Feb 12, 2020

Focuslock component used by Reactour sometimes closes menus, dropdowns and modals, affecting page behavior.

elrumordelaluz and others added 30 commits September 24, 2019 14:39
@elrumordelaluz
Remove unused file
1b55d34
@elrumordelaluz
Improve actionBefore behaviour
c8c4edb
@elrumordelaluz
Update dependencies
a048f5e
@elrumordelaluz
Update dependencies
fbc4a8a
@elrumordelaluz
Update dependencies
5c2b71f
@elrumordelaluz
Remove lodash.pick dependency
48bc0e4
@elrumordelaluz
Update dependencies
f58c40b
@elrumordelaluz
Update dependencies
4cc6bec
@nelsonwong1012
Added option to add aria-label attribute to each step's navigation dot
749d50b
@elrumordelaluz
Update dependencies
0b6b9a8
@elrumordelaluz
Update dependencies
67a968c
@elrumordelaluz
Round translate values to avoid text blurring in browser
7c34ab2 
closes elrumordelaluz#183
@tarqu1n
checkFnAndRun is not in scope in useEffect so replace with manual che…
43061be 
…ck for function existance.
@tarqu1n
checkFnAndRun is out of scope after building, fallign back to manual …
088f171 
…check.
@tarqu1n
ensure tour step dialog starts centered but does not attempt to cente…
9c774db 
…r between starting a new step and the 'actionBefore' function completing.
@tarqu1n
ensure tour can be started at specific step.
c6ab7f5
@tarqu1n
added notes for updates from fork
8beb0ab
@tarqu1n
ensure mask click event is IE11 compatible.
6849116
@tarqu1n
reverse custom readme changes for PR
b93a1b5
@tarqu1n
ensure default for startStep prop is set.
bd164ef
@tarqu1n
update docs to show default value for start at prop.
c065f08
@elrumordelaluz
Merge branch 'tarqu1n-temp-bug-fixes'
72504ed 
closes elrumordelaluz#206
@elrumordelaluz
Update readme
5dc6dc9
@elrumordelaluz
Fix demo (CustomHelper) arrow event
f37fffc 
closes elrumordelaluz#215
@elrumordelaluz
Fix demo
36ffe10
@elrumordelaluz
Update dependencies
951318f
ensure inital open triggers the opening steps actionBefore function
7f595bf
@elrumordelaluz
Merge pull request elrumordelaluz#216 from tarqu1n/bugfix-actionbefor…
cbfe3d8 
…e-first-step

Fix start step actionBefore
@elrumordelaluz
yarn upgrade
3222544
@elrumordelaluz
Merge branch 'nav-dot-aria-labels' of https://github.com/nelsonwong10…
2a062a7 
…12/reactour into nelsonwong1012-nav-dot-aria-labels
elrumordelaluz and others added 13 commits January 9, 2020 11:53
@elrumordelaluz
Merge branch 'nelsonwong1012-nav-dot-aria-labels'
32a774f
@nelsonwong1012
Add role="dialog" for accessibility
facbe7c
@elrumordelaluz
Merge pull request elrumordelaluz#220 from nelsonwong1012/aria_role_d…
5c40031 
…ialog

Add role="dialog" for accessibility
@nelsonwong1012
Add prop for close button aria-label
3c45702
@nelsonwong1012
Render close button if showCloseButton is true
0c79d70
@nelsonwong1012
defaultProp for closeButtonAriaLabel
50a4e05
@elrumordelaluz
Merge pull request elrumordelaluz#222 from nelsonwong1012/close_butto…
12211bd 
…n_aria_label

aria-label option for close button
@nelsonwong1012
Prop to add aria-labelledby attribute for accessibility
9ee4f0e
@elrumordelaluz
Merge pull request elrumordelaluz#223 from nelsonwong1012/aria_labell…
1c3a518 
…edby

aria-labelledby
@nelsonwong1012
showNavigationScreenReaders prop to control showing/hiding the naviga…
2c51677 
…tion dot for screen reader software
@nelsonwong1012
Combined a11y related props into a single prop
ad18a34
@elrumordelaluz
Merge pull request elrumordelaluz#228 from nelsonwong1012/nav-dots-ar…
3e37d1f 
…ia-hidden-combine-a11y-options

prop to hide nav from screen readers, combine a11y props
add props disableFocusLock
1324a4a
@bellsml bellsml mentioned this pull request Feb 12, 2020
Closed
@PeterKottas
Copy link

Hello all! What is the status of this? I've seen similar problems. I wanted to open a PR but I can see this was already implemented. Is there a reason for it now being merged?

@PeterKottas
Copy link

Also, I am curious if you managed to find any workaround for the time being @bellsml . I tried using FreeFocusInside explained in more detail here with no luck.

@elrumordelaluz
Copy link
Owner

Hi @PeterKottas and @bellsml.
First of all, I'm sorry to focus :) this Issue just now and not before. No problem at all with that implementation. Mind any of you implement the same behaviour to PR in the v1 which is the stable branch published. The idea for the v2 is to remove the lib to replace with another or play with some hooks, since there were lots of issues related on focus.

Hope you understand and thanks you!

@bellsml
Copy link
Author

bellsml commented Apr 7, 2020

@PeterKottas
I'm using the repository I forked for now...

@PeterKottas
Copy link

@elrumordelaluz great news indeed! :) @bellsml would you be able to update the PR? Forking and using that is understandably an option but not for the long run. Best to have it in here! Cheers guys ;)

@bellsml bellsml changed the base branch from master to v1 April 7, 2020 14:09
@bellsml bellsml closed this Apr 7, 2020
@bellsml bellsml deleted the feature/flag-to-disable-focuslock branch April 7, 2020 15:16
@bellsml
Copy link
Author

bellsml commented Apr 7, 2020

@PeterKottas
yes, I agree.
the project I'm working on is still under development

@elrumordelaluz
Sorry, now I realized I was doing everything on the master branch.
I had to do another PR for v1.

Please check if I got it right this time:
#253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elrumordelaluz elrumordelaluz Awaiting requested review from elrumordelaluz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bellsml @PeterKottas @elrumordelaluz @nelsonwong1012 @tarqu1n