Increase default code editor height

elsa-workflows · Jun 17, 2021 · d1c73d5 · d1c73d5
1 parent ab15169
commit d1c73d5
Show file tree

Hide file tree

Showing 12 changed files with 6 additions and 12 deletions.
diff --git a/src/designer/elsa-workflows-studio/src/components/controls/elsa-monaco/elsa-monaco.tsx b/src/designer/elsa-workflows-studio/src/components/controls/elsa-monaco/elsa-monaco.tsx
@@ -19,7 +19,7 @@ export class ElsaMonaco {
 
   monaco = (window as any).monaco;
 
-  @Prop({attribute: 'editor-height', reflect: true}) editorHeight: string = '6em';
+  @Prop({attribute: 'editor-height', reflect: true}) editorHeight: string = '5em';
   @Prop() value: string;
   @Prop() language: string;
   @Prop({attribute: 'single-line', reflect: true}) singleLineMode: boolean = false;

diff --git a/...udio/src/components/editors/elsa-multi-expression-editor/elsa-multi-expression-editor.tsx b/...udio/src/components/editors/elsa-multi-expression-editor/elsa-multi-expression-editor.tsx
@@ -16,7 +16,7 @@ export class ElsaMultiExpressionEditor {
   @Prop() defaultSyntax: string = SyntaxNames.Literal;
   @Prop() expressions: Map<string> = {};
   @Prop() supportedSyntaxes: Array<string> = [];
-  @Prop({attribute: 'editor-height', reflect: true}) editorHeight: string = '6em';
+  @Prop({attribute: 'editor-height', reflect: true}) editorHeight: string = '10em';
   @Prop({attribute: 'single-line', reflect: true}) singleLineMode: boolean = false;
   @Prop({attribute: 'context', reflect: true}) context?: string;
 

diff --git a/...lsa-workflows-studio/src/components/editors/elsa-property-editor/elsa-property-editor.tsx b/...lsa-workflows-studio/src/components/editors/elsa-property-editor/elsa-property-editor.tsx
@@ -11,7 +11,7 @@ export class ElsaPropertyEditor {
     @Event() defaultSyntaxValueChanged: EventEmitter<string>;
     @Prop() propertyDescriptor: ActivityPropertyDescriptor;
     @Prop() propertyModel: ActivityDefinitionProperty;
-    @Prop({attribute: 'editor-height', reflect: true}) editorHeight: string = '6em';
+    @Prop({attribute: 'editor-height', reflect: true}) editorHeight: string = '10em';
     @Prop({attribute: 'single-line', reflect: true}) singleLineMode: boolean = false;
     @Prop({attribute: 'context', reflect: true}) context?: string;
     @Prop() showLabel: boolean = true;

diff --git a/...o/src/components/editors/properties/elsa-check-list-property/elsa-check-list-property.tsx b/...o/src/components/editors/properties/elsa-check-list-property/elsa-check-list-property.tsx
@@ -56,7 +56,6 @@ export class ElsaCheckListProperty {
       <elsa-property-editor propertyDescriptor={propertyDescriptor}
                             propertyModel={propertyModel}
                             onDefaultSyntaxValueChanged={e => this.onDefaultSyntaxValueChanged(e)}
-                            editor-height="2.75em"
                             single-line={true}>
         <div class="elsa-max-w-lg elsa-space-y-3 elsa-my-4">
           {items.map((item, index) => {

diff --git a/...tudio/src/components/editors/properties/elsa-checkbox-property/elsa-checkbox-property.tsx b/...tudio/src/components/editors/properties/elsa-checkbox-property/elsa-checkbox-property.tsx
@@ -39,7 +39,6 @@ export class ElsaCheckBoxProperty {
       <elsa-property-editor propertyDescriptor={propertyDescriptor}
                             propertyModel={propertyModel}
                             onDefaultSyntaxValueChanged={e => this.onDefaultSyntaxValueChanged(e)}
-                            editor-height="2.75em"
                             single-line={true}
                             showLabel={false}>
         <div class="elsa-max-w-lg">

diff --git a/...tudio/src/components/editors/properties/elsa-dropdown-property/elsa-dropdown-property.tsx b/...tudio/src/components/editors/properties/elsa-dropdown-property/elsa-dropdown-property.tsx
@@ -45,7 +45,6 @@ export class ElsaDropdownProperty {
       <elsa-property-editor propertyDescriptor={propertyDescriptor}
                             propertyModel={propertyModel}
                             onDefaultSyntaxValueChanged={e => this.onDefaultSyntaxValueChanged(e)}
-                            editor-height="2.75em"
                             single-line={true}>
         <select id={fieldId} name={fieldName} onChange={e => this.onChange(e)} class="elsa-mt-1 elsa-block focus:elsa-ring-blue-500 focus:elsa-border-blue-500 elsa-w-full elsa-shadow-sm sm:elsa-max-w-xs sm:elsa-text-sm elsa-border-gray-300 elsa-rounded-md">
           {items.map(item => {

diff --git a/...o/src/components/editors/properties/elsa-multi-line-property/elsa-multi-line-property.tsx b/...o/src/components/editors/properties/elsa-multi-line-property/elsa-multi-line-property.tsx
@@ -24,7 +24,7 @@ export class ElsaMultiLineProperty {
         return {propertyEditor: '20em', textArea: 6}
       case 'Default':
       default:
-        return {propertyEditor: '8em', textArea: 3}
+        return {propertyEditor: '15em', textArea: 3}
     }
   }
 

diff --git a/...o/src/components/editors/properties/elsa-multi-text-property/elsa-multi-text-property.tsx b/...o/src/components/editors/properties/elsa-multi-text-property/elsa-multi-text-property.tsx
@@ -68,7 +68,6 @@ export class ElsaMultiTextProperty {
       <elsa-property-editor propertyDescriptor={propertyDescriptor}
                             propertyModel={propertyModel}
                             onDefaultSyntaxValueChanged={e => this.onDefaultSyntaxValueChanged(e)}
-                            editor-height="2em"
                             single-line={true}>
         {elsaInputTags}
       </elsa-property-editor>

diff --git a/...o/src/components/editors/properties/elsa-radio-list-property/elsa-radio-list-property.tsx b/...o/src/components/editors/properties/elsa-radio-list-property/elsa-radio-list-property.tsx
@@ -53,7 +53,6 @@ export class ElsaRadioListProperty {
       <elsa-property-editor propertyDescriptor={propertyDescriptor}
                             propertyModel={propertyModel}
                             onDefaultSyntaxValueChanged={e => this.onDefaultSyntaxValueChanged(e)}
-                            editor-height="2.75em"
                             single-line={true}>
         <div class="elsa-max-w-lg elsa-space-y-3 elsa-my-4">
           {items.map((item, index) => {

diff --git a/...src/components/editors/properties/elsa-single-line-property/elsa-single-line-property.tsx b/...src/components/editors/properties/elsa-single-line-property/elsa-single-line-property.tsx
@@ -43,7 +43,7 @@ export class ElsaSingleLineProperty {
       <elsa-property-editor propertyDescriptor={propertyDescriptor}
                             propertyModel={propertyModel}
                             onDefaultSyntaxValueChanged={e => this.onDefaultSyntaxValueChanged(e)}
-                            editor-height="2.75em"
+                            editor-height="5em"
                             single-line={true}>
         <input type="text" id={fieldId} name={fieldName} value={value} onChange={e => this.onChange(e)} class="focus:elsa-ring-blue-500 focus:elsa-border-blue-500 elsa-block elsa-w-full elsa-min-w-0 elsa-rounded-md sm:elsa-text-sm elsa-border-gray-300"/>
       </elsa-property-editor>

diff --git a/...c/components/editors/properties/elsa-switch-cases-property/elsa-switch-cases-property.tsx b/...c/components/editors/properties/elsa-switch-cases-property/elsa-switch-cases-property.tsx
@@ -105,7 +105,6 @@ export class ElsaSwitchCasesProperty {
                                 language={monacoLanguage}
                                 single-line={true}
                                 padding="elsa-pt-1.5 elsa-pl-1 elsa-pr-28"
-                                editor-height="2.75em"
                                 onExpressionChanged={e => this.onCaseExpressionChanged(e, switchCase)}
                             />
                             <div class="elsa-absolute elsa-inset-y-0 elsa-right-0 elsa-flex elsa-items-center">

diff --git a/src/samples/dashboard/aspnetcore/ElsaDashboard.Samples.AspNetCore.Monolith/Startup.cs b/src/samples/dashboard/aspnetcore/ElsaDashboard.Samples.AspNetCore.Monolith/Startup.cs
@@ -65,9 +65,9 @@ public void Configure(IApplicationBuilder app, IWebHostEnvironment env)
 
             app.UseCors();
             app.UseStaticFiles();
-            app.UseHttpActivities();
             app.UseRouting();
             app.UseAuthorization();
+            app.UseHttpActivities();
             app.UseEndpoints(endpoints =>
             {
                 // Elsa Server uses ASP.NET Core Controllers.