Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elasticsearch store does not work with workflow instances #4963

Closed
ayalros opened this issue Feb 19, 2024 · 2 comments
Closed

Elasticsearch store does not work with workflow instances #4963

ayalros opened this issue Feb 19, 2024 · 2 comments
Labels
bug Something isn't working elsa 3 This issue is specific to Elsa 3
Milestone

Comments

@ayalros
Copy link
Contributor

ayalros commented Feb 19, 2024

Hi there,

While using the elastic store and the studio, loading workflow instances resultes in an error.
Maybe i'm missing something but, while debugging i found several issues creating the query:

  1. the query section gets initiated with a null value resulting in a bad query. (
    if (!string.IsNullOrWhiteSpace(filter.SearchTerm))
    )
  2. while in the fields section the field "createdAt" is written correctly, in the order by section its beeing written not in camel case form (e,g. "CreatedAt"). (
    var propName = order.KeySelector.GetPropertyName();
    )

Reagrds,

Copy link

glime-ai bot commented Feb 19, 2024

Based on the context provided, it seems like you are encountering issues with the Elsa Workflow Elasticsearch store when trying to load workflow instances. The issues you've described suggest there might be bugs in the implementation of the WorkflowInstanceStore class for the Elasticsearch module of Elsa.

  1. If the query section is initiated with a null value, this could indeed result in a malformed query. This would need to be addressed in the codebase, potentially by ensuring that the query is properly initialized before being used.

  2. The inconsistency in the case of the "createdAt" field between the fields section and the order by section could also lead to issues, especially if the Elasticsearch index has strict case sensitivity for field names.

To resolve these issues, you may need to report them to the Elsa Workflow GitHub repository as bugs. The maintainers of the project would then be able to investigate and provide fixes. If you are comfortable with coding, you could also attempt to fix these issues yourself and submit a pull request to the repository.

For now, I would recommend checking the GitHub issues for Elsa Workflow to see if these problems have already been reported or fixed in a newer version. If not, you should create new issues providing the details you've shared here.

Unfortunately, without access to the actual codebase and the ability to make changes, there's not much more that can be done from a customer support perspective. You would need to engage with the development community for Elsa Workflow to seek a resolution.

If you need further assistance or guidance on how to report these issues, please let me know.

ayalros pushed a commit to ayalros/elsa-core that referenced this issue Feb 19, 2024
@sfmskywalker sfmskywalker added bug Something isn't working elsa 3 This issue is specific to Elsa 3 labels Feb 20, 2024
@sfmskywalker sfmskywalker added this to the Elsa 3.1 milestone Feb 20, 2024
sfmskywalker pushed a commit that referenced this issue Feb 20, 2024
Co-authored-by: אייל רוסמן <ayalr@edanel.co.il>
@sfmskywalker
Copy link
Member

Thanks for reporting the issue, and the PR! 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working elsa 3 This issue is specific to Elsa 3
Projects
Status: Done
Development

No branches or pull requests

2 participants