Fixed bug where multiple activity registrations of the same type would cause duplicate key exception #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame workflow type would cause dup key exception
…ow done in AddElsa()
|
Apologies, I've just seen #124 . feel free to put in a different fix if you think that's better. I only saw this because Sample12 was registering UserTask twice. |
sfmskywalker
approved these changes
Nov 5, 2019
|
No worries, this is a good fix. We can revisit the activity registration story later if we deem it necessary. Thanks for the PR 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce, run Sample12 on 1.1.1 branch and you'll get a duplicate key exception.
The registration was being performed twice, once by AddElsa() and again by AddUserTasks(). You could probably remove the AddUserTasks() extension method altogether.