Credential manager #2897
Merged
Credential manager #2897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohdali
reviewed
Mar 31, 2022
| { | ||
| /// <summary> | ||
| /// Allowed databases to run SQL | ||
| /// </summary> | ||
| [ActivityInput( | ||
| UIHint = ActivityInputUIHints.Dropdown, | ||
| Hint = "Allowed databases to run SQL.", | ||
| Options = new[] { "MSSQL Server", "PostgreSql" }, | ||
| Options = new[] { "", "MSSQLServer", "PostgreSql" }, |
There was a problem hiding this comment.
Is this still required? I submitted a fix in Elsa 2.6 to make the first option selected by default.
There was a problem hiding this comment.
Updated in latest revision.
|
Can this be completed anytime soon? I have similar requirement to centrally manage the connection strings especially when moving from staging to production environment and need to update the connection string in each activity. |
|
@mohdali sorry it took so much time to get back to you, developer who was working on the feature is no longer available, so it will take some more time before it can be finalized and merged. |
sfmskywalker
requested changes
Jul 25, 2022
src/designer/elsa-workflows-studio/src/modules/credential-manager/models/secret.model.ts
Outdated
Show resolved
Hide resolved
src/designer/elsa-workflows-studio/src/modules/credential-manager/models/secret.model.ts
Outdated
Show resolved
Hide resolved
src/designer/elsa-workflows-studio/src/modules/credential-manager/models/secret.model.ts
Outdated
Show resolved
Hide resolved
src/designer/elsa-workflows-studio/src/modules/credential-manager/models/secret.model.ts
Outdated
Show resolved
Hide resolved
src/designer/elsa-workflows-studio/src/modules/credential-manager/models/secret.model.ts
Outdated
Show resolved
Hide resolved
src/modules/secrets/Elsa.Secrets/Persistence/Decorators/EventPublishingSecretsStore.cs
Outdated
Show resolved
Hide resolved
src/modules/secrets/Elsa.Secrets/Persistence/Decorators/InitializingSecretsStore.cs
Outdated
Show resolved
Hide resolved
sfmskywalker
requested changes
Aug 8, 2022
src/activities/Elsa.Activities.Http/Activities/SendHttpRequest/SendHttpRequest.cs
Outdated
Show resolved
Hide resolved
src/activities/Elsa.Activities.Sql/Activities/SqlCommand/ExecuteSqlCommand.cs
Outdated
Show resolved
Hide resolved
...er/elsa-workflows-studio/src/modules/credential-manager/models/secrets/sqlserver.activity.ts
Show resolved
Hide resolved
...r/elsa-workflows-studio/src/modules/credential-manager/services/credential-manager.client.ts
Outdated
Show resolved
Hide resolved
Closed
sfmskywalker
approved these changes
Aug 17, 2022
sfmskywalker
added a commit
that referenced
this pull request
Aug 29, 2022
* Adding sample to demonstrate how to write activity extended from HTTPEndpoint * Adding IsBrowseable to output properties * Hiding getConfig from TS definition if not enabled * Removing input properties from TS definition * Describing sample activity derived from HttpEndpoint in few details * Telnyx activity improvements * Credential manager (#2897) * initial components * credential-manager-list cmp * add/edit secret modal window, UI generaion * small UI updates * base api & store implementation * basic crud implemenation, added elsaClient & requests * edit secret, code clenup * code cleanup & adjustments * modal window UI updates(removed tabs) * added new secret, minor adjustments * integrated credential manager into sql activities * added ampty elements to dropdowns * added credential support in http activity * added MongoDb support * Merged master into credential-manager * enabled credential manager plugin * merged missing bugfixes and improvements * deleted SQL activity https://stackoverflow.com/questions/18000138/duplicated-file-with-different-case-in-git-origin-bitbucket * added back SQL activity https://stackoverflow.com/questions/18000138/duplicated-file-with-different-case-in-git-origin-bitbucket * fixed merge master issues * fixed another issue due to incorrect merge * refactored, removed secret dependencies * updated secrets module according to PR comments Co-authored-by: Konstantins Vedenins <konstantins.vedenins@gmail.com> * Enable support for input/output props * revert port number * Added Tenant Signaler Implementation and Options (#3250) * Fixing the subscription input * Added Tenant Signaler Co-authored-by: Jonathan Ruckert <jruckert@novaworks.com.au> * Fixing faulted activity display in Journal as well as workflow that remain in running state after fault. (#3251) * Prevent rescheduling of looping/scoped activities if faulted (#3252) * Prevent rescheduling of looping/scoped activities if faulted * Update RescheduleBranchingActivitiesAndContainers.cs * Add build + dispatch demo * Add sample with background mediator event handling * Removing designer workflow export * Adding sample to demonstrate how to write activity extended from HTTPEndpoint * Adding IsBrowseable to output properties * Hiding getConfig from TS definition if not enabled * Removing input properties from TS definition * Describing sample activity derived from HttpEndpoint in few details * Removing designer workflow export * Update WorkflowRunner.cs * Reorder root initializing event Give plugins a chance to perform work while root component initializes * Update index.html * Squashed commit of the following: commit 900a95e Author: Sipke Schoorstra <sipkeschoorstra@outlook.com> Date: Tue Aug 23 20:51:00 2022 +0200 Add Auth0 / JWT Bearer authentication sample commit 0e8313b Author: Sipke Schoorstra <sipkeschoorstra@outlook.com> Date: Tue Aug 23 20:36:01 2022 +0200 Update index.html commit ba9288c Author: Sipke Schoorstra <sipkeschoorstra@outlook.com> Date: Tue Aug 23 20:29:56 2022 +0200 Add auth0 designer module commit 4bbd763 Author: Sipke Schoorstra <sipkeschoorstra@outlook.com> Date: Tue Aug 23 20:29:29 2022 +0200 Refactor plugin manager Add support for plugin factory functions instead of types. This allows the host app to configure plugin properties. * Bump designer version * Update auth0 plugin to not redirect when not properly configured * Adding sample to demonstrate how to write activity extended from HTTPEndpoint * Adding IsBrowseable to output properties * Hiding getConfig from TS definition if not enabled * Removing input properties from TS definition * Describing sample activity derived from HttpEndpoint in few details * Removing designer workflow export * Adding sample to demonstrate how to write activity extended from HTTPEndpoint * Removing designer workflow export * Update Elsa.sln * Fixing sln Co-authored-by: Sipke Schoorstra <sipkeschoorstra@outlook.com> Co-authored-by: andrewkorol <andrewkorol01@gmail.com> Co-authored-by: Konstantins Vedenins <konstantins.vedenins@gmail.com> Co-authored-by: Mohamed Ali <antivirus.cs@gmail.com> Co-authored-by: Jonathan Ruckert <4064588+jruckert@users.noreply.github.com> Co-authored-by: Jonathan Ruckert <jruckert@novaworks.com.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.