Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various ITenantAccessor/Multitenancy fixes #2992

Merged
merged 3 commits into from
May 6, 2022
Merged

Various ITenantAccessor/Multitenancy fixes #2992

merged 3 commits into from
May 6, 2022

Conversation

tomy2105
Copy link
Contributor

@tomy2105 tomy2105 commented May 3, 2022 •
edited

This solves #2989 (11bfcfd) and #2994 (44ae915) and #2861 (8f5cde7).

@tomy2105 tomy2105 force-pushed the #2989---API-to-list-workflow-definitions-does-not-respect-ITenantAccessor branch from e87d40a to 8f5cde7 Compare May 5, 2022 15:27
@tomy2105 tomy2105 changed the title Instance List now observes ITenantAccessor Various ITenantAccessor fixes May 5, 2022
@tomy2105 tomy2105 changed the title Various ITenantAccessor fixes Various ITenantAccessor/Multitenancy fixes May 5, 2022
@tomy2105
HttpEndpointMiddleware invokes ITennatAccessor
8f5cde7 
Revert package lock commit

Revert "Revert package lock commit"

This reverts commit 5867231.

Revert "HttpEndpointMiddleware invokes ITennatAccessor"

This reverts commit e77441f.

HttpEndpointMiddleware invokes ITennatAccessor
@sfmskywalker sfmskywalker merged commit f076fa5 into elsa-workflows:master May 6, 2022
@sfmskywalker
Copy link
Member

Thanks @tomy2105 !

This was referenced May 6, 2022
Closed
Closed
Closed
@tomy2105 tomy2105 deleted the #2989---API-to-list-workflow-definitions-does-not-respect-ITenantAccessor branch May 10, 2022 12:39
@VartikaSharma14
Copy link

VartikaSharma14 commented Jul 14, 2022 •
edited

Hello @sfmskywalker
Having some issue as I am trying to use Elsa as multi-tenant system at record level.
Scenarios is:
I have created one workflow in which first activity is WatchDirectory with some tenantid. When I copy the file on specified location, workflow doesnot get executed.
But when I set the TenantId = null, then the workflow gets triggered.
When I checked the WatchDirectory code, this activity does not invoke ITenantAccessor.
Kindly help!

@VartikaSharma14 VartikaSharma14 mentioned this pull request Jul 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfmskywalker sfmskywalker sfmskywalker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tomy2105 @sfmskywalker @VartikaSharma14