Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist blob metadata changes #3116

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Persist blob metadata changes #3116

merged 1 commit into from
Jun 23, 2022

Conversation

stuartmcgillivray
Copy link

Adding await _blobStorage.SetBlobAsync(blob, cancellationToken); to persist changes to the metadata so binary data is correctly delt with when read back.

#3115

@dnfadmin
Copy link

dnfadmin commented Jun 8, 2022

CLA assistant check
All CLA requirements met.

@jdevillard
Copy link
Contributor

why don't we use directly the blob property instead of the blob metadata for the content-type? maybe it's not available through the storage.net abstraction?

@sfmskywalker
Copy link
Member

@stuartmcgillivray Any thoughts on @jdevillard 's suggestion?

@stuartmcgillivray
Copy link
Author

It doesn't appear to expose that option at least through the S3 provider I am looking at.

I can see content-type is available as a header though the object returned by the s3 client but that doesn't get transfered to the Blob.

@sfmskywalker
Copy link
Member

I checked as well, but couldn't find a way to create a Blob first and provide the stream/bytes to upload, or to provide the bytes + blob properties in one go.

Let's go with this solution for now, since at least it fixes an issue. A future SDK update might allow us to upload a blob + metadata at the same time.

@sfmskywalker sfmskywalker merged commit da901d4 into elsa-workflows:master Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants