Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MongoDb Provider - Switch to LINQ2 #4001

Merged
merged 1 commit into from May 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
@@ -1,5 +1,6 @@
using System;
using Elsa.Persistence.MongoDb.Options;
using Elsa.Persistence.MongoDb.Services;
using Elsa.Webhooks.Models;
using Elsa.Webhooks.Persistence.MongoDb.Data;
using Microsoft.Extensions.Options;
Expand All @@ -11,9 +12,8 @@ public class ElsaMongoDbContext
{
public ElsaMongoDbContext(IOptions<ElsaMongoDbOptions> options)
{
var connectionString = options.Value.ConnectionString;
var mongoClient = new MongoClient(connectionString);
var databaseName = options.Value.DatabaseName is not null and not "" ? options.Value.DatabaseName : MongoUrl.Create(connectionString).DatabaseName;
var mongoClient = ElsaMongoDbDriverHelpers.CreateClient(options.Value);
var databaseName = options.Value.DatabaseName is not null and not "" ? options.Value.DatabaseName : MongoUrl.Create(options.Value.ConnectionString).DatabaseName;

if (databaseName == null)
throw new Exception("Please specify a database name, either via the connection string or via the DatabaseName setting.");
Expand Down
Expand Up @@ -4,7 +4,7 @@
<Import Project="..\..\..\..\configureawait.props"/>

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<TargetFrameworks>netcoreapp3.1;net5.0;net6.0;net7.0</TargetFrameworks>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<Description>
Expand Down
@@ -1,4 +1,5 @@
using Elsa.Persistence.MongoDb.Options;
using Elsa.Persistence.MongoDb.Services;
using Elsa.Secrets.Models;
using Elsa.Secrets.Persistence.MongoDb.Data;
using Microsoft.Extensions.Options;
Expand All @@ -10,9 +11,8 @@ public class ElsaMongoDbContext
{
public ElsaMongoDbContext(IOptions<ElsaMongoDbOptions> options)
{
var connectionString = options.Value.ConnectionString;
var mongoClient = new MongoClient(connectionString);
var databaseName = options.Value.DatabaseName is not null and not "" ? options.Value.DatabaseName : MongoUrl.Create(connectionString).DatabaseName;
var mongoClient = ElsaMongoDbDriverHelpers.CreateClient(options.Value);
var databaseName = options.Value.DatabaseName is not null and not "" ? options.Value.DatabaseName : MongoUrl.Create(options.Value.ConnectionString).DatabaseName;

if (databaseName == null)
throw new Exception("Please specify a database name, either via the connection string or via the DatabaseName setting.");
Expand Down
Expand Up @@ -4,7 +4,7 @@
<Import Project="..\..\..\..\configureawait.props" />

<PropertyGroup>
<TargetFrameworks>netcoreapp3.1;net5.0;net6.0;net7.0</TargetFrameworks>
<TargetFrameworks>netstandard2.1;net5.0;net6.0;net7.0</TargetFrameworks>
<Description>
Elsa Workflow Settings is an optional part of Elsa Workflows.
This package provides a MongoDb persistence provider.
Expand Down
@@ -1,5 +1,6 @@
using System;
using Elsa.Persistence.MongoDb.Options;
using Elsa.Persistence.MongoDb.Services;
using Elsa.WorkflowSettings.Models;
using Elsa.WorkflowSettings.Persistence.MongoDb.Data;
using Microsoft.Extensions.Options;
Expand All @@ -11,9 +12,8 @@ public class ElsaMongoDbContext
{
public ElsaMongoDbContext(IOptions<ElsaMongoDbOptions> options)
{
var connectionString = options.Value.ConnectionString;
var mongoClient = new MongoClient(connectionString);
var databaseName = options.Value.DatabaseName is not null and not "" ? options.Value.DatabaseName : MongoUrl.Create(connectionString).DatabaseName;
var mongoClient = ElsaMongoDbDriverHelpers.CreateClient(options.Value);
var databaseName = options.Value.DatabaseName is not null and not "" ? options.Value.DatabaseName : MongoUrl.Create(options.Value.ConnectionString).DatabaseName;

if (databaseName == null)
throw new Exception("Please specify a database name, either via the connection string or via the DatabaseName setting.");
Expand Down
Expand Up @@ -4,7 +4,7 @@
<Import Project="..\..\..\configureawait.props"/>

<PropertyGroup>
<TargetFramework>netstandard2.1</TargetFramework>
<TargetFrameworks>netstandard2.1;net5.0;net6.0;net7.0</TargetFrameworks>
<Description>
Elsa is a set of workflow libraries and tools that enable super-fast workflowing capabilities in any .NET Core application.
This package provides a MongoDb persistence provider.
Expand Down
Expand Up @@ -10,5 +10,12 @@ public class ElsaMongoDbOptions
/// <see cref="Elsa.Persistence.MongoDb.Serializers.VariablesSerializer"/>
/// </summary>
public bool DoNotRegisterVariablesSerializer { get; set; }

/// <summary>
/// If true it will use the new LINQ3 provider introduced in MongoDB.Driver 2.19.0 but
/// it has some breaking changes, so it is preferibly to enable only if you are really sure
/// that it works without any problem in your project.
/// </summary>
public bool UseNewLinq3Provider { get; set; }
}
}
Expand Up @@ -10,9 +10,8 @@ public class ElsaMongoDbContext : IElsaMongoDbContext
{
public ElsaMongoDbContext(IOptions<ElsaMongoDbOptions> options)
{
var connectionString = options.Value.ConnectionString;
var mongoClient = new MongoClient(connectionString);
var databaseName = options.Value.DatabaseName is not null and not "" ? options.Value.DatabaseName : MongoUrl.Create(connectionString).DatabaseName;
var mongoClient = ElsaMongoDbDriverHelpers.CreateClient(options.Value);
var databaseName = options.Value.DatabaseName is not null and not "" ? options.Value.DatabaseName : MongoUrl.Create(options.Value.ConnectionString).DatabaseName;

if (databaseName == null)
throw new Exception("Please specify a database name, either via the connection string or via the DatabaseName setting.");
Expand Down
@@ -0,0 +1,33 @@
using Elsa.Persistence.MongoDb.Options;
using MongoDB.Driver;
using System;
using System.Collections.Concurrent;

namespace Elsa.Persistence.MongoDb.Services
{
public static class ElsaMongoDbDriverHelpers
{
/// <summary>
/// Avoid creating too much instances for MongoClient.
/// </summary>
private static readonly ConcurrentDictionary<string, MongoClient> _clients = new();

public static MongoClient CreateClient(ElsaMongoDbOptions options)
{
if (string.IsNullOrEmpty(options.ConnectionString)) throw new ArgumentException("Connection string is required.", nameof(options.ConnectionString));
if (!_clients.TryGetValue(options.ConnectionString, out MongoClient client))
{
var connectionString = options.ConnectionString;
var clientSettings = MongoClientSettings.FromConnectionString(connectionString);
if (options.UseNewLinq3Provider == false)
{
clientSettings.LinqProvider = MongoDB.Driver.Linq.LinqProvider.V2;
}
client = new MongoClient(clientSettings);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the client be added to the dictionary?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woopsie 👍 good catch, I've missed adding to dictionary when I copied from internal project. Fixed Thanks.

_clients[options.ConnectionString] = client;
}

return client;
}
}
}