Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle exceptions generated from ActivityTypeProviders #4033

Merged
merged 1 commit into from May 15, 2023

Conversation

mohdali
Copy link
Member

@mohdali mohdali commented May 12, 2023

If an ActivityType provider generates an exception it will cause the /activities endpoint to fail and the missing triggers will cause the runtime to stop.

This attempts to handle those exceptions that may be caused by external dependencies and improve the engine robustness.

@mohdali mohdali requested a review from sfmskywalker May 12, 2023 06:30
Copy link
Member

@sfmskywalker sfmskywalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sfmskywalker sfmskywalker merged commit 716ff3b into master May 15, 2023
7 checks passed
@sfmskywalker sfmskywalker deleted the bugfix/activity-type-provider branch May 15, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants