add Elsa.EntityFrameworkCore.MySql #4047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
sfmskywalker
approved these changes
May 21, 2023
src/modules/Elsa.EntityFrameworkCore.MySql/Elsa.EntityFrameworkCore.MySql.csproj
Outdated
Show resolved
Hide resolved
johnwc
reviewed
May 22, 2023
There was a problem hiding this comment.
@sfmskywalker shouldn't this file be named MySqlDesignTimeDbContextFactoryBase.cs rather than SqlServerDesignTimeDbContextFactoryBase.cs
There was a problem hiding this comment.
fixed it. Thanks for the review!
added 2 commits
May 22, 2023 19:49
sfmskywalker
approved these changes
May 25, 2023
Elsa.sln
Outdated
Comment on lines
10
to
22
| ProjectSection(SolutionItems) = preProject | ||
| README.md = README.md | ||
| docker-compose.yml = docker-compose.yml | ||
| common.props = common.props | ||
| configureawait.props = configureawait.props | ||
| .gitignore = .gitignore | ||
| icon.png = icon.png | ||
| .github\workflows\packages.yml = .github\workflows\packages.yml | ||
| .github\workflows\all-in-one-web.yml = .github\workflows\all-in-one-web.yml | ||
| build-and-run-all-in-one-web-docker.sh = build-and-run-all-in-one-web-docker.sh | ||
| NuGet.Config = NuGet.Config | ||
| .github\workflows\npm-packages.yml = .github\workflows\npm-packages.yml | ||
| EndProjectSection |
There was a problem hiding this comment.
this indentation seems to have appeared out of nowhere. Could be tooling, but if you don't mind, can you undo this please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds v3 mysql support #3996