Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 get type definitions request #4353

Merged
merged 3 commits into from
Aug 24, 2023

Conversation

sNakiex
Copy link
Contributor

@sNakiex sNakiex commented Aug 23, 2023

Add the Refit request to retrieve type definitions.

I am not sure if it's okay to have this request in the WorkflowDefinitions interface.
If not please let me know where you want it and i'll refactor.

Add GetTypeDefinitions Refit request
Add the Request model.
@sfmskywalker
Copy link
Member

Hey @sNakiex

Thanks for the PR! I suggest introducing an IJavaScriptApi interface. It'll mirror the server-side REST API endpoint on the client side, providing a consistent client-side representation. Can you make this adjustment?

Cheers

@sNakiex
Copy link
Contributor Author

sNakiex commented Aug 24, 2023

Hello @sfmskywalker ,
That's no problem! Should I create a Resources folder called Scripting and place the IJavaScriptApi contract in there?
That might be a nice way to already have boilerplate folders for additional scripting endpoints if required in the future.

@sfmskywalker
Copy link
Member

Yes that sounds perfect, thanks @sNakiex !

Copy link
Member

@sfmskywalker sfmskywalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍🏻

@sfmskywalker sfmskywalker merged commit 811f8b4 into elsa-workflows:v3 Aug 24, 2023
1 of 2 checks passed
@sNakiex sNakiex deleted the v3-GetTypeDefinitionsRequest branch August 25, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants