Fix Default Workflow Runtime Race condition #4362
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes race condition that can occur if a new workflow instance is started and is resumed in the meantime, e.g. as a side effect of the workflow executing and triggering external events, which in turn trigger workflow bookmarks.
=== auto-pr-body ===
Summary:
IDictionary<string, object?>?
for ActivityState, Payload, and Outputs in ActivityExecutionRecord classInput<string>(CallControlId)
andcontext.GetPrimaryCallControlId
Input<string>(CallControlIdA and CallControlIdB)
andcontext.GetSecondaryCallControlId
Input<string>(CallControlId)
andcontext.GetPrimaryCallControlId
List of Changes:
CallControlId
input fromstring?
tostring
in GatherUsingSpeak.cs, HangupCallBase.cs, IncomingCall.cs and PlayAudioBase.csElsa.Extensions
in HangupCallBase.csCallControlId
input fromstring?
tostring
in SpeakTextBase.csInput
extension methodsRefactoring Target:
CallControlId
parameters to more meaningful names (e.g.SourceCallId
andDestinationCallId
).CallControlId
. This could serve to ensure that all activities that useCallControlId
have access to it in the same way.