New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed IsNameUnique for InMemory WorkflowDefinition store #4370

Merged

sfmskywalker merged 1 commit into elsa-workflows:v3 from yspanj:v3

Aug 29, 2023

Contributor

yspanj commented Aug 29, 2023

IWorkflowDefinitionStore GetIsNameUnique only inverted the result in the InMemoryStore, and it was inverted again in the endpoint.

I changed the GetIsNameUnique to return false when the name already exists, and removed the invert in the endpoint.

This should fix the issue seen in elsa-workflows/elsa-studio#29


          Fixed IsNameUnique for InMemory WorkflowDefinition store

aef721b

sfmskywalker approved these changes

View reviewed changes

Member

sfmskywalker left a comment

Thanks!

sfmskywalker merged commit 2c014a9 into elsa-workflows:v3

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment