Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement resumable downloads #4448

Merged
merged 13 commits into from
Sep 17, 2023
Merged

Conversation

sfmskywalker
Copy link
Member

@sfmskywalker sfmskywalker commented Sep 17, 2023

This PR adds the ability to resume interrupted downloads.

If the file is a zip file that was generated on the fly, it will be cached (when enabled), allowing the client to download parts of the zip file.

=== auto-pr-body ===

Summary
This pull request introduces changes to the Elsa workflow providers that enable stronger abstraction for working with blobs in the workflow persistence engine. These changes include renaming some classes and methods, changing some method parameters and return types, and adding error handling checks. Suggested refactoring includes moving code to shared helper methods, renaming endpoint classes, moving methods to the Configure method in the ElsaEndpoint class, and adding validation for parameters in the Execute endpoint.

@sfmskywalker sfmskywalker added the elsa 3 This issue is specific to Elsa 3 label Sep 17, 2023
@sfmskywalker sfmskywalker changed the title Implemente resumable downloads Implement resumable downloads Sep 17, 2023
@sfmskywalker sfmskywalker merged commit cb87d2e into v3 Sep 17, 2023
2 checks passed
@sfmskywalker sfmskywalker deleted the v3-write-file-http-response-blob-cache branch September 17, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
elsa 3 This issue is specific to Elsa 3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant