Missing WorkflowPassCompleted enum element in WorkflowPersistenceBehavior.cs #4480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-policy-service agree |
|
Thanks for the PR! I'm wondering if it's enough to just add the enum? Should there be some logic somewhere that checks for this value and take appropriate action? |
|
I found only one place where it would make sense to put logic behind it, in PersistWorkflow handler. |
| @@ -27,7 +27,7 @@ public async Task Handle(WorkflowExecutionPassCompleted notification, Cancellati | |||
| { | |||
| var behavior = notification.WorkflowExecutionContext.WorkflowBlueprint.PersistenceBehavior; | |||
|
|
|||
| if (behavior == WorkflowPersistenceBehavior.ActivityExecuted || notification.ActivityExecutionContext.ActivityBlueprint.PersistWorkflow) | |||
| if (behavior == WorkflowPersistenceBehavior.ActivityExecuted || behavior == WorkflowPersistenceBehavior.WorkflowPassCompleted || notification.ActivityExecutionContext.ActivityBlueprint.PersistWorkflow) | |||
There was a problem hiding this comment.
Aha. So, I think this may have been the reason I removed WorkflowPassCompleted in the past - it has effectively the same result as ActivityExecuted.
That being said, let's keep your changes in case we want to actually make a difference between the two behaviors.
sfmskywalker
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Elsa.Abstractions there is enum for serialization of existing workflows in blob storage. WorkflowPassCompleted is missing there.