Include transient variables in merged variables for JavaScriptEngine Access #4769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Access ## Summary This pull request introduces changes to the handling of transient variables in the `WorkflowExecutionContext.cs`. The aim is to include transient variables in the merged variables collection, enhancing their accessibility to the JavaScriptEngine. This change is expected to improve the functionality and flexibility of variable handling within workflows. ## Changes - Modified the `GetMergedVariables()` method in `WorkflowExecutionContext.cs` to start the aggregation with the TransientState and then merge the `WorkflowInstance.Variables` at the end. This ensures that transient variables are included in the merged variables. ## Added - A new test case in `WorkflowExecutionContextTests.cs` to verify that transient variables set in the execution context are retrievable in the merged variable collection after the changes. ## Impact These changes allow for transient variables to be more accessible and functional within the JavaScriptEngine, enhancing the overall workflow execution capabilities.
|
@dotnet-policy-service agree |
sfmskywalker
approved these changes
Jan 15, 2024
JoostVanVelthoven
deleted the
fix/4713-include-transient-variables-in-merged-variables
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces changes to the handling of transient variables in the
WorkflowExecutionContext.cs. #4713 The aim is to include transient variables in the merged variables collection, enhancing their accessibility to the JavaScriptEngine. This change is expected to improve the functionality and flexibility of variable handling within workflows.Changes
GetMergedVariables()method inWorkflowExecutionContext.csto start the aggregation with the TransientState and then merge theWorkflowInstance.Variablesat the end. This ensures that transient variables are included in the merged variables.Added
WorkflowExecutionContextTests.csto verify that transient variables set in the execution context are retrievable in the merged variable collection after the changes.Impact
These changes allow for transient variables to be more accessible and functional within the JavaScriptEngine, enhancing the overall workflow execution capabilities.