Remove StringObjectDictionaryConverter and update JintJavaScriptEvaluator #4856
Conversation
…ator The StringObjectDictionaryConverter class was removed as it is no longer necessary. Instead, the JintJavaScriptEvaluator now wraps objects in ObjectWrapper instances and sets their prototype to Array.prototype if they are array-like. This allows for more convenient and intuitive use of Lists and arrays in JavaScript code within Elsa. A new integration test was created to validate this functionality.
A new unit test class is added in the IntegrationTests project. The class, located in the JavaScriptListAndArray directory, focuses on testing the engine's ability to handle JavaScript list and array-like objects.
sfmskywalker
requested review from
cristinamudura,
MariusVuscanNx and
raymonddenhaan
sfmskywalker
added
elsa 3
There was a problem hiding this comment.
It would be nice to test whether this works as expected with arrays, objects and primitives
There was a problem hiding this comment.
Sure. What additional scenarios do you have in mind, specifically? The current test covers dealing with Lists as Arrays.
There was a problem hiding this comment.
Nested Lists, primitives and objects as the root object and maybe a test with an array instead of a list, just to see that this functionality doesn't somehow break that.
There was a problem hiding this comment.
Ah, like that. Yes, makes sense 👍🏻
There was a problem hiding this comment.
I added a few more cases that mixes primitives, objects and regular array: #4857
Do let me know if you see an opportunity for adding more cases.
There was a problem hiding this comment.
I think that with those cases you've covered most of the scenarios. Maybe some edge cases we're still missing, but it is good enough for now.
A new ObjectArrayHelper class has been added into the Elsa.JavaScript module to improve array detection. The previous IsArrayLike method used in JintJavaScriptEvaluator and integration tests has been replaced by the DetermineIfObjectIsArrayLikeClrCollection method from this helper. These changes also provoked an update of the Jint package version from 3.0.0-beta-2057 to 3.0.0.
The StringObjectDictionaryConverter class was removed as it is no longer necessary. Instead, the JintJavaScriptEvaluator now wraps objects in ObjectWrapper instances and sets their prototype to Array.prototype if they are array-like. This allows for more convenient and intuitive use of Lists and arrays in JavaScript code within Elsa. A new integration test was created to validate this functionality.