Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to use Central Package Management #4877

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

lahma
Copy link
Contributor

@lahma lahma commented Feb 4, 2024

  • Now all versions are defined in root level Directory.Packages.props, some special casing based original net6.0, net7.0, net8.0 checks
  • Moved commont test package refererences (xunit, Microsoft test SDK, coverlet) to tests\Directory.build.props which cleaned the test csprojs too
  • Add GitHubActionsTestLogger which will show a better summary about tests and possible problems - see the output at the bottom now

@lahma
Copy link
Contributor Author

lahma commented Feb 4, 2024

@sfmskywalker I see that you removed the v3* branch selection, when you modify the build definition you need to run build.cmd locally afterwards in order for NUKE to regenerate the GH Actions workflow. This PR contains the updated workflow file was was generated when I executed NUKE.

@lahma lahma marked this pull request as ready for review February 4, 2024 10:00
@lahma
Copy link
Contributor Author

lahma commented Feb 4, 2024

FastEndPoints had two different versions between NET6/7 and NET8: 5.19.2 and 5.21.2. I didn't see a reason to have two separate for these and thus I used common version ref 5.21.2. Can split back to framework dependant if needed.

* Add GitHubActionsTestLogger
@sfmskywalker
Copy link
Member

Dude this is amazing - a massive thank you! 🙌🏻

@sfmskywalker
Copy link
Member

@sfmskywalker I see that you removed the v3* branch selection, when you modify the build definition you need to run build.cmd locally afterwards in order for NUKE to regenerate the GH Actions workflow. This PR contains the updated workflow file was was generated when I executed NUKE.

Will do! Thanks for pointing it out 👍🏻

@sfmskywalker sfmskywalker merged commit 45a2984 into elsa-workflows:main Feb 4, 2024
2 checks passed
@sfmskywalker
Copy link
Member

@lahma
I should probably have asked this before merging the PR, but not knowing too much about CPM, do you know what effect this will have on user projects referencing a subset of Elsa packages - will they automatically inherit ALL package references in Directory.Packages.props? 🤔

@sfmskywalker
Copy link
Member

Ah I think I see. So projects still explicitly reference the packages they need, but without version number; that is all managed centrally now.

@lahma
Copy link
Contributor Author

lahma commented Feb 4, 2024

@lahma
I should probably have asked this before merging the PR, but not knowing too much about CPM, do you know what effect this will have on user projects referencing a subset of Elsa packages - will they automatically inherit ALL package references in Directory.Packages.props? 🤔

It's the same csproj dictated dependencies. The versions are just managed centrally in one file. So if project X references Polly it will be part of nuget package deps, but a non-referenced Jint won't be.

@lahma lahma deleted the cpm branch February 4, 2024 14:37
@lahma
Copy link
Contributor Author

lahma commented Feb 4, 2024

Rider and Visual Studio also have native support for updating these via Ui/finding updates. Of course the Condition-based versions need to be carefully updated - but now in one place!

@sfmskywalker sfmskywalker added the elsa 3 This issue is specific to Elsa 3 label Feb 9, 2024
@sfmskywalker sfmskywalker added this to the Elsa 3.1 milestone Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
elsa 3 This issue is specific to Elsa 3
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

2 participants