issues(4885)

[bbenameur]

Hello,
See issue:
#4885

Based on the context provided, it appears that we are encountering a serialization registration issue when running integration tests with Elsa and MongoDB. The error message indicates that a serializer for the Object type is being registered multiple times, which is not allowed by the MongoDB driver.

The code snippet provided suggests a solution to use BsonSerializer.TryRegisterSerializer instead of BsonSerializer.RegisterSerializer.

private static void RegisterSerializers()
{
    BsonSerializer.TryRegisterSerializer(typeof(object), new PolymorphicSerializer());
    BsonSerializer.TryRegisterSerializer(typeof(Type), new TypeSerializer());
    BsonSerializer.TryRegisterSerializer(typeof(Variable), new VariableSerializer());
    BsonSerializer.TryRegisterSerializer(typeof(Version), new VersionSerializer());
    BsonSerializer.TryRegisterSerializer(typeof(JsonElement), new JsonElementSerializer());
}

[bbenameur]

@sfmskywalker can you please see and approve this PR ?

[bbenameur]

@dotnet-policy-service agree

[dotnet-policy-service]

@bbenameur the command you issued was incorrect. Please try again.

Examples are:

@dotnet-policy-service agree

and

@dotnet-policy-service agree company="your company"

[bbenameur]

@dotnet-policy-service agree

[hsnsalhi]

this doesn't resolve the problem since TryRegisterSerializer throws an exception in addition to returning false if it couldn't register the serializer.
I suggest to put the code in a try catch block in a separate method to ensure the registration of every serializer even if one of them couldn't be registered.

        private static void RegisterSerializers()
        {
            TryRegisterSerializerWithoutException(typeof(object), new PolymorphicSerializer());
            TryRegisterSerializerWithoutException(typeof(Type), new TypeSerializer());
            TryRegisterSerializerWithoutException(typeof(Variable), new VariableSerializer());
            TryRegisterSerializerWithoutException(typeof(Version), new VersionSerializer());
            TryRegisterSerializerWithoutException(typeof(JsonElement), new JsonElementSerializer());
        }


        private static void TryRegisterSerializerWithoutException(Type type, IBsonSerializer serializer)
        {
            try
            {
                BsonSerializer.TryRegisterSerializer(type, serializer);
            }
            catch (BsonSerializationException ex)
            {
                // should we log the exception ?
            }
        }

[hsnsalhi]

BTW, you will face the same problem with RegisterClassMap. I suggest you to replace it by TryRegisterClassMap this method does not throw an exception if it cannot register the class map. so no need to put a try catch block for it.

        private static void RegisterClassMaps()
        {
            BsonClassMap.TryRegisterClassMap<StoredBookmark>(cm =>
            {
                cm.AutoMap(); // Automatically map other properties
                cm
                    .MapIdProperty(b => b.BookmarkId)
                    .SetSerializer(new StringSerializer(BsonType.String));
            });
        }