Respond with 500 in case of Incidents #5004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The handling for workflow faults in the Workflow Middleware has been altered. Previously, the code was checking if the workflow state status was designated as 'Faulted'. Now it checks if there are any incidents or problems in the workflow state, which provides a more comprehensive fault check.
Added checks in the 'Delete' and 'PagedDelete' methods in the 'Store.cs' file to prevent the deletion of all records if the conditions are empty. This will protect the system from unintentional data loss by stopping the execution of these methods when they have no parameters.
sfmskywalker
requested review from
cristinamudura,
jdevillard,
MariusVuscanNx,
mohdali and
raymonddenhaan
sfmskywalker
added
bug
raymonddenhaan
approved these changes
Feb 26, 2024
| @@ -245,6 +245,11 @@ public async Task<long> DeleteAsync(Action<ParameterizedQuery> filter, Cancellat | |||
| { | |||
| var query = _dbConnectionProvider.CreateQuery().Delete(TableName); | |||
| filter(query); | |||
|
|
|||
| // If there are no conditions, we don't want to delete all records. | |||
| if (!query.Parameters.ParameterNames.Any()) | |||
There was a problem hiding this comment.
Do we want to support a delete all statement?
There was a problem hiding this comment.
Probably eventually, yes, but I couldn't think of a decent solution on the spot, and I don't think we have a current use case for it that warrants additional work on the Dapper provider.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5003