Made loading workflows more robust #5074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| if (latestWorkflowDefinition.Version > workflow.Identity.Version) | ||
| { | ||
| _logger.LogWarning("A more recent version of the workflow has been found, overwriting the IsLatest property on the workflow."); |
There was a problem hiding this comment.
Log event messages should be fragments, not sentences. Avoid a trailing period/full stop.
| { | ||
| if (publishedWorkflowDefinition.Version > workflow.Identity.Version) | ||
| { | ||
| _logger.LogWarning("A more recent version of the workflow has been found to be published, overwriting the IsPublished property on the workflow."); |
There was a problem hiding this comment.
Log event messages should be fragments, not sentences. Avoid a trailing period/full stop.
src/modules/Elsa.Workflows.Runtime/Services/DefaultWorkflowDefinitionStorePopulator.cs
Show resolved
Hide resolved
sfmskywalker
approved these changes
Mar 14, 2024
raymonddenhaan
force-pushed
the
fix/workflow-populator
branch
from
162511b
to
43a12f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5033 and other issues with importing workflow definitions through background processes.