Remove unused BulkExtensions #5160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The whitespace after the if conditional in packages.yml was unused and unnecessary. This commit ensures to remove those to promote cleaner, more efficient code.
The package version in the GitHub workflows configuration (.github/workflows/packages.yml) has been updated from 3.1.0 to 3.2.0. This change reflects version updates in the package management system.
|
Thank you @Suchiman , we will have a look and release a patch soon. |
sfmskywalker
approved these changes
Apr 2, 2024
sfmskywalker
approved these changes
Apr 2, 2024
sfmskywalker
added a commit
that referenced
this pull request
Apr 2, 2024
* Remove unused BulkExtensions (#5160) * Remove unnecessary whitespace in packages.yml The whitespace after the if conditional in packages.yml was unused and unnecessary. This commit ensures to remove those to promote cleaner, more efficient code. * Update default package version in GitHub workflows The package version in the GitHub workflows configuration (.github/workflows/packages.yml) has been updated from 3.1.0 to 3.2.0. This change reflects version updates in the package management system. * Remove unused BulkExtensions --------- Co-authored-by: Sipke Schoorstra <sipkeschoorstra@outlook.com> * Use PolySharp for automatic polyfilling (#5161) * Remove unnecessary whitespace in packages.yml The whitespace after the if conditional in packages.yml was unused and unnecessary. This commit ensures to remove those to promote cleaner, more efficient code. * Update default package version in GitHub workflows The package version in the GitHub workflows configuration (.github/workflows/packages.yml) has been updated from 3.1.0 to 3.2.0. This change reflects version updates in the package management system. * Use PolySharp for automatic polyfilling PolySharp is a design time only dependency which will analyze which polyfills are needed for the currently building target framework and will then source generate only the needed polyfills. Also they're internal by default so they don't conflict. fixes #5157 --------- Co-authored-by: Sipke Schoorstra <sipkeschoorstra@outlook.com> * Update patch version in packages workflow The packages.yml workflow has been updated to reference patch version 3.1.2 instead of 3.1.1. This ensures the workflow correctly identifies and handles updates tagged with this new version. --------- Co-authored-by: Robin Sue <robinsue@live.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EFCore.BulkExtensions.MITbrings in all the database provider packages and is currently unused, so remove it for now.If this is actually used in the future, i would recommend depending on the individual packages
from inside the Database specific packages such as
instead of from the
Elsa.EntityFrameworkCore.Commonproject.fixes #5158
Btw. i hope it's possible to release this and #5161 without having to wait 2 months for
v3.2