Refactored handling/updating of the ActivityRegistry #5468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymonddenhaan
force-pushed
the
enhancement/5373_publish
branch
2 times, most recently
from
2d95ca3
to
23d27d4
Compare
raymonddenhaan
changed the title
|
closes #5464 |
sfmskywalker
requested changes
Jun 4, 2024
src/modules/Elsa.Dsl/Interpreters/WorkflowDefinitionBuilderInterpreter/VisitObject.cs
Outdated
Show resolved
Hide resolved
src/modules/Elsa.JavaScript/Services/JintJavaScriptEvaluator.cs
Outdated
Show resolved
Hide resolved
src/modules/Elsa.Workflows.Core/Contexts/WorkflowExecutionContext.cs
Outdated
Show resolved
Hide resolved
src/modules/Elsa.Workflows.Core/Contracts/IActivityRegistryLookupService.cs
Outdated
Show resolved
Hide resolved
src/modules/Elsa.Workflows.Management/Contracts/IActivityRegistryPopulator.cs
Outdated
Show resolved
Hide resolved
src/modules/Elsa.Workflows.Management/Notifications/WorkflowDefinitionVersionsUpdate.cs
Outdated
Show resolved
Hide resolved
src/modules/Elsa.Workflows.Management/Notifications/WorkflowDefinitionVersionsUpdated.cs
Outdated
Show resolved
Hide resolved
src/modules/Elsa.Workflows.Management/Notifications/WorkflowDefinitionVersionsUpdating.cs
Outdated
Show resolved
Hide resolved
src/modules/Elsa.Workflows.Management/Services/WorkflowDefinitionManager.cs
Show resolved
Hide resolved
raymonddenhaan
force-pushed
the
enhancement/5373_publish
branch
from
8450fd7
to
4019825
Compare
sfmskywalker
requested changes
Jun 6, 2024
src/modules/Elsa.Workflows.Core/Contracts/IActivityRegistryUpdateService.cs
Outdated
Show resolved
Hide resolved
src/modules/Elsa.Workflows.Core/Services/ActivityRegistryUpdateService.cs
Outdated
Show resolved
Hide resolved
sfmskywalker
approved these changes
Jun 7, 2024
Updated event handling to only update activity registry for workflows marked as usable as activity
This commit removes unnecessary calls related to populating activity registry and reinitializing workflow definitions.
Added Refreshing of registry on miss when searching
Fixed handling of UsableAsActivity property on definitions
Fixed updating the ActivityRegistry when workflows get updated due to the `auto update consuming workflows` option
raymonddenhaan
force-pushed
the
enhancement/5373_publish
branch
from
f8e1aca
to
0cf51d2
Compare
Improved logging Added missing comments
…ailable" This reverts commit b4d62e1.
This commit changes the reference to the logger instance in the DefaultTriggerScheduler class. It corrects the reference from a private instance to the correct instance 'logger'. Moreover, the string formatting of the second logger warning message has been updated for standardization.
raymonddenhaan
force-pushed
the
enhancement/5373_publish
branch
from
0cf51d2
to
8a1d0fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored handling/updating of the ActivityRegistry
This change is