Skip to content

Commit

Permalink
Rename WorkflowDefinitionVersionUpdated to WorkflowDefinitionVersionS…
Browse files Browse the repository at this point in the history
…elected

The callback for when a workflow definition version is updated has been renamed to better reflect its purpose. It is now called "WorkflowDefinitionVersionSelected", as it is triggered when a version is selected, not when it's updated. This change affects several files, with updates to both function and parameter names.
  • Loading branch information
sfmskywalker committed Feb 3, 2024
1 parent 892a48b commit aacfd6e
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
@page "/workflow-definitions/{definitionId}"
@using Elsa.Api.Client.Resources.WorkflowDefinitions.Models
@rendermode InteractiveServer
<WorkflowDefinitionEditorWrapper @ref="Editor" DefinitionId="@DefinitionId" WorkflowDefinitionVersionUpdated="@OnWorkflowDefinitionVersionUpdated"/>
<WorkflowDefinitionEditorWrapper @ref="Editor" DefinitionId="@DefinitionId" WorkflowDefinitionVersionSelected="@WorkflowDefinitionVersionSelected"/>

<MudButton OnClick="@OnClick">Get Current Version</MudButton>

Expand All @@ -15,7 +15,7 @@

private WorkflowDefinitionEditorWrapper Editor { get; set; } = default!;

private Task OnWorkflowDefinitionVersionUpdated(WorkflowDefinition arg)
private Task WorkflowDefinitionVersionSelected(WorkflowDefinition arg)
{
return Task.CompletedTask;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
@inherits BackendComponentBase

<ThemedComponentWrapper>
<WorkflowDefinitionEditor DefinitionId="@DefinitionId" WorkflowDefinitionExecuted="WorkflowDefinitionExecuted" WorkflowDefinitionVersionUpdated="WorkflowDefinitionVersionUpdated"/>
<WorkflowDefinitionEditor DefinitionId="@DefinitionId" WorkflowDefinitionExecuted="WorkflowDefinitionExecuted" WorkflowDefinitionVersionSelected="WorkflowDefinitionVersionSelected"/>
</ThemedComponentWrapper>

@code
Expand All @@ -23,7 +23,7 @@
/// Gets or sets the event that occurs when the workflow definition version is updated.
/// </summary>
[Parameter]
public EventCallback<WorkflowDefinition> WorkflowDefinitionVersionUpdated { get; set; }
public EventCallback<WorkflowDefinition> WorkflowDefinitionVersionSelected { get; set; }

private WorkflowDefinitionEditor WorkflowDefinitionEditor { get; set; } = default!;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public partial class WorkflowDefinitionWorkspace : IWorkspace
/// Gets or sets the event that occurs when the workflow definition version is updated.
/// </summary>
[Parameter]
public EventCallback<WorkflowDefinition> WorkflowDefinitionVersionUpdated { get; set; }
public EventCallback<WorkflowDefinition> WorkflowDefinitionVersionSelected { get; set; }

/// <summary>
/// An event that is invoked when the workflow definition is updated.
Expand Down Expand Up @@ -63,8 +63,8 @@ public void DisplayWorkflowDefinitionVersion(WorkflowDefinition workflowDefiniti
{
SelectedWorkflowDefinition = workflowDefinition;

if (WorkflowDefinitionVersionUpdated.HasDelegate)
WorkflowDefinitionVersionUpdated.InvokeAsync(SelectedWorkflowDefinition);
if (WorkflowDefinitionVersionSelected.HasDelegate)
WorkflowDefinitionVersionSelected.InvokeAsync(SelectedWorkflowDefinition);

StateHasChanged();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<ActivityPicker/>
</RadzenSplitterPane>
<RadzenSplitterPane Size="85%">
<WorkflowDefinitionWorkspace @ref="WorkflowDefinitionWorkspace" WorkflowDefinition="@_workflowDefinition" WorkflowDefinitionVersionUpdated="WorkflowDefinitionVersionUpdated" WorkflowDefinitionExecuted="WorkflowDefinitionExecuted"/>
<WorkflowDefinitionWorkspace @ref="WorkflowDefinitionWorkspace" WorkflowDefinition="@_workflowDefinition" WorkflowDefinitionVersionSelected="WorkflowDefinitionVersionSelected" WorkflowDefinitionExecuted="WorkflowDefinitionExecuted"/>
</RadzenSplitterPane>
</RadzenSplitter>
</CascadingValue>
Expand All @@ -35,7 +35,7 @@
/// Gets or sets the event that occurs when the workflow definition version is updated.
/// </summary>
[Parameter]
public EventCallback<WorkflowDefinition> WorkflowDefinitionVersionUpdated { get; set; }
public EventCallback<WorkflowDefinition> WorkflowDefinitionVersionSelected { get; set; }

/// <summary>
/// Gets the currently selected workflow definition version.
Expand Down

0 comments on commit aacfd6e

Please sign in to comment.