Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update graphql-batch to dataloader for N+1 query solution #328

Closed
POPPIN-FUMI opened this issue Aug 30, 2022 · 0 comments
Closed

Update graphql-batch to dataloader for N+1 query solution #328

POPPIN-FUMI opened this issue Aug 30, 2022 · 0 comments

Comments

@POPPIN-FUMI
Copy link
Contributor

currently graphql-batch has been implemented in souls as default.

remove this module

https://github.com/elsoul/souls/blob/master/apps/api/app/utils/association_loader.rb

and

Let's change it to dataloader since it's using fiber and graphql-ruby 's default.

we need to make apps/api/app/graphql/sources dir for dataloader fetch file like user_by_id.rb

Dataloader
https://graphql-ruby.org/dataloader/overview.html

POPPIN-FUMI added a commit that referenced this issue Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant