Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Commanded EGR command #11

Merged
merged 1 commit into from
Oct 9, 2020
Merged

Add Commanded EGR command #11

merged 1 commit into from
Oct 9, 2020

Conversation

ojacquemart
Copy link
Contributor

Hello,

Nice project 馃憤

This PR is related to the #9

I found your project through the https://goodfirstissues.com/ website 馃槈

@eltonvs eltonvs self-assigned this Oct 8, 2020
@eltonvs
Copy link
Owner

eltonvs commented Oct 8, 2020

Hey @ojacquemart

First, thank you so much for your contribution!
The code is looking good, the only thing I ask you before I approve is to change the target branch to develop so it can be part of the next release 馃槃

@ojacquemart ojacquemart changed the base branch from master to development October 9, 2020 07:12
@ojacquemart
Copy link
Contributor Author

Hi @eltonvs,

Thanks for your feedback 馃槈
I changed the base branch.

@eltonvs eltonvs closed this Oct 9, 2020
@eltonvs
Copy link
Owner

eltonvs commented Oct 9, 2020

Sorry, closed by mistake 馃槄

Thanks for making the change!

@eltonvs eltonvs reopened this Oct 9, 2020
@eltonvs eltonvs merged commit 9bc0f5f into eltonvs:development Oct 9, 2020
@eltonvs eltonvs linked an issue Oct 9, 2020 that may be closed by this pull request
Add EGR Error Command #10
Closed
@eltonvs eltonvs removed a link to an issue Oct 9, 2020
Add EGR Error Command #10
Closed
@eltonvs eltonvs linked an issue Oct 9, 2020 that may be closed by this pull request
Add Commanded EGR Command #9
Closed
@eltonvs eltonvs added this to the 1.1.2 milestone Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eltonvs eltonvs eltonvs approved these changes

Assignees

@eltonvs eltonvs

Labels
None yet
Projects
None yet
Milestone
1.1.2
Development

Successfully merging this pull request may close these issues.

Add Commanded EGR Command
2 participants
@ojacquemart @eltonvs