Add Fuel Rail Pressure Command #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relative to eltonvs#8
ojacquemart
force-pushed
the
feature/fuel-rail-pressure
branch
from
00cb751
to
e78bcd6
Compare
eltonvs
approved these changes
Oct 12, 2020
There was a problem hiding this comment.
Hey @ojacquemart thanks for the second PR and finding this small issue!
Code LGTM. As the existing command was changed, this is considered a breaking change, so I'll defer the deployment of this to the next minor version (1.2.0).
|
@eltonvs It was a pleasure 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relative to #8
In fact, there was already a Fuel Rail Pressure Command which was the Fuel Rail Gauge Pressure Command. I renamed it and add the new one. WDYT?