feat: implement simple plugins #3
Conversation
examples/plugins/__main__.py
Outdated
| import sail | ||
|
|
||
| logging.basicConfig() | ||
| logging.getLogger().setLevel(logging.DEBUG) |
There was a problem hiding this comment.
Can't you set the level directly in the basicConfig function?
There was a problem hiding this comment.
I may not remember this correctly but I'm pretty sure setting it in basicConfig is global and for all loggers as opposed to just the logger in this file.
There was a problem hiding this comment.
That's the point? This is an example, not a module part of the library.
There was a problem hiding this comment.
getLogger() without an arg also uses the global logger, so that doesn't change the behaviour either.
There was a problem hiding this comment.
Yup, though I'm probably leaving out the log setup altogether when I finish up this example (note how there's no comments explaining anything yet), as it's only there as I needed it to debug stuff.
There was a problem hiding this comment.
Yeeted this in c5d2b41. I'll add a bit of logging explanation later when I get around to properly documenting this example, as plugins do actually support setting per-instance loggers.
|
How will state be managed? 🤔 |
Though I probably misunderstood the question -- as of right now, not a single model is stateful, and I'm kinda inclined to keep it that way (not that Eludris currently has anything that warrants maintaining state locally). The client can be accessed through the |
|
Since it's supposed to be inspired by Hikari I'm talking about stuff like injections. You speak of replacing the cache but how will you get the same db client across all plugins? |
|
Ah like that. Yeah, as of right now the only real typesafe way would be to create the cache instance in its own file and quite literally import it into all files that need it. As for possible solutions, I'm indeed leaning towards some flavour of dependency injection, though some kind of simple datastore could do the trick as well. |
I should probably add a simple logging setup to the actual plugin though
|
I think it's gonna be very hard to make a type-safe datastore. Injections are the most elegant solution IMO. Although I suppose you could inject a datastore lol. |
This PR adds simple plugins and extensions, which can be used to place commands and listeners in separate files. Furthermore, plugins can be loaded, unloaded and reloaded as desired, to hot-reload code, etc. This should lead to an overall better development experience. Registering sub-modules to a plugin is a planned feature, but will be delayed to a future PR.