[knex#3033] fix: add tests, fix hasColumn

src/dialects/sqlite3/schema/compiler.js

@@ -26,7 +26,12 @@ SchemaCompiler_SQLite3.prototype.hasColumn = function(tableName, column) {
   this.pushQuery({
     sql: `PRAGMA table_info(${this.formatter.wrap(tableName)})`,
     output(resp) {
-      return some(resp, { name: column });
+      return some(resp, (col) => {
+        return (
+          this.client.wrapIdentifier(col.name) ===
+          this.client.wrapIdentifier(column)
+        );
+      });
     },
   });
 };

src/dialects/sqlite3/schema/ddl.js

@@ -30,7 +30,12 @@ function SQLite3_DDL(client, tableCompiler, pragma, connection) {
 
 assign(SQLite3_DDL.prototype, {
   getColumn: Promise.method(function(column) {
-    const currentCol = find(this.pragma, { name: column });
+    const currentCol = find(this.pragma, (col) => {
+      return (
+        this.client.wrapIdentifier(col.name) ===
+        this.client.wrapIdentifier(column)
+      );
+    });
     if (!currentCol)
       throw new Error(
         `The column ${column} is not in the ${this.tableName} table`

src/util/snake-case-mappers.js

@@ -0,0 +1,34 @@
+import { isArray, isObject, snakeCase, camelCase, mapKeys } from 'lodash';
+
+function mapResponseItem(item) {
+  if (!isObject(item)) {
+    return item;
+  }
+
+  return mapKeys(item, (val, key) => {
+    return camelCase(key);
+  });
+}
+
+export function postProcessResponse(response) {
+  if (isArray(response)) {
+    return response.map(mapResponseItem);
+  } else {
+    return mapResponseItem(response);
+  }
+}
+
+export function wrapIdentifier(id, origImpl) {
+  // _.snakeCase removes the leading _ and places _ in front of numbers,
+  // mangling the temp table names.
+  if (id.startsWith('_knex_temp_alter')) {
+    return origImpl(id);
+  }
+
+  const parts = id.split('.', 2);
+  const prefix = parts.length === 2 ? parts[0] + '.' : '';
+  const toWrap = prefix ? parts[1] : parts[0];
+  return origImpl(
+    prefix + (toWrap.startsWith('_') ? '_' : '') + snakeCase(toWrap)
+  );
+}