add missing R5 source mapping for ST60 series #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elupus
reviewed
Jun 18, 2023
removing unsupported zone 2 sources
minor cosmetic changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying the current code with Home-Assistant and i notice that some source mapping was till missing.
I also started ignoring the
0x00byte coming from ST60 as discussed before.I've also replaced the way the increment and decrement volume commands are sent, since the RC commands only support navigate up and navigate down, which changes the volume when device is in home screen, if the device is in another screen/menu does not work.
Using native commands is more clean and more robust.