allow get-smart-home-mode #82
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
Seems rather pointless to just get a notification. Seem it would be better to provide an entity. |
|
Agreed that an entity would be a better solution, however the get_smart_home_mode service allows getting the smart-home-mode in the short term, could we merge this pull request and create a separate branch for getting smart home mode as an entity? |
|
Adding the entity should be quite easy now that the code has been re-factored a bit. It should behave similarly to thermostats, sending state once in a while to keep control. I might look at it soon ish. |
|
Bump (humbly) @elupus :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.