Correct CREATE TABLE IF NOT EXISTS syntax for MSSQL #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 28, 2023 06:46
Removed need to query sys.tables
joshmcrae
reviewed
Nov 27, 2023
| @@ -135,7 +135,7 @@ public function getLastId() | |||
| */ | |||
| public function getSchemaVersion() | |||
| { | |||
| $this->pdo->exec("IF (SELECT [object_id] FROM [sys].[tables] WHERE [object_id] = OBJECT_ID('".$this->schemaTable."')) IS NULL CREATE TABLE [".$this->schemaTable."] ([version] INT DEFAULT '0')"); | |||
| $this->pdo->exec("IF (OBJECT_ID('".$this->schemaTable."')) IS NULL CREATE TABLE [".$this->schemaTable."] ([version] INT DEFAULT '0')"); | |||
There was a problem hiding this comment.
@Mr-Kaos are the parens around OBJECT_ID(...) necessary? Other examples I've seen of this approach omit them, e.g.
IF OBJECT_ID("table_name") IS NULL ...
There was a problem hiding this comment.
The parentheses are not required around OBJECT_ID(...). I had only included them to make the contents of the IF statement clear.
joshmcrae
approved these changes
Nov 28, 2023
alankoroma
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes changes the syntax present in the Mssql driver's
getSchemaVersion()function to be acceptable T-SQL syntax.T-SQL does not support the
CREATE TABLE IF EXISTSsyntax so theOBJECT_IDfunction must be used instead to check if such database object exists.There were two commits made in this pull request, the first being a bit longer, but guarantees that the ID returned by
OBJECT_IDis a table and not another database object such as a view or function.One thing to keep in mind though is that the provided fix only works for tables in the default
dbodatabase schema. Tables that are in another schema will need to have their schema specified. For example, the schema in the snippet below is prepended before the table name, spearated by a period: