fix(issue-510): support Additional state to be passed as the IntersectionObserverEntry #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinlli
commented
Aug 23, 2023
xinlli
commented
- support Additional state to be passed as the IntersectionObserverEntry
- yarn test
…tionObserverEntry
elwayman02
reviewed
Aug 23, 2023
| @@ -39,22 +39,26 @@ class MockIntersectionObserver { | |||
| /** | |||
| * Force a single element to enter the viewport | |||
| * @param {String} el - a DOM selector string | |||
| * @param {object} [state] Additional state to be passed as the IntersectionObserverEntry | |||
There was a problem hiding this comment.
Lets type this as IntersectionObserverEntry instead of object?
|
Can you update the testing docs as well to note people can construct and pass their own IntersectionObserverEntry? |
elwayman02
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.