Add sinon v18 to peerDependencies #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elwayman02
reviewed
Jun 19, 2024
SergeAstapov
force-pushed
the
add-sinon-v18-peer-dep
branch
from
5c90510
to
554502f
Compare
elwayman02
approved these changes
Jun 19, 2024
|
Thanks! I'll try to get this released soonish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sinon v18 was release a month ago https://www.npmjs.com/package/sinon?activeTab=versions
This change allows package managers to properly install and handle that version when
ember-sinon-qunitis also used